Fix race condition in testLifecycleOperations, Serialize updateContainer() calls, Ignore irrelevant container events #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial container gets started and immediately stopped via the CLI. The events propagate through the UI asynchronously, so strengthen the initial wait to ensure that the container is actually shown as "Exited". Otherwise it could still be "Running" in the UI, and trying to open the action menu would not show "Start".
With a burst of events these get called in parallel. But podman does not return them in the call order [1], which led to non-current state updates. [1] containers/podman#19124
martinpitt
force-pushed
the
fixes
branch
2 times, most recently
from
a8183c4 to
c10a8aa
Compare
martinpitt
changed the title
marusak
reviewed
Jul 13, 2023
martinpitt
changed the title
martinpitt
changed the title
|
testHealthcheck is still very flaky. But that already happens on main, investigating in #1324 (comment) . So retrying. |
marusak
reviewed
Jul 14, 2023
marusak
previously approved these changes
Jul 14, 2023
These are internal transient states which don't need to reflect in the UI. They happen quickly in bursts, with a "permanent state" event following such as "create", "died", or "remove". This helps to reduce the API calls and thus mitigates out-of-order results; see containers/podman#19124 We are not really interested in `podman exec` events, so we would like to ignore `exec_died` along with `exec`. However, it is the only thing that saves us from inconsistent `health_state` events (see containers/podman#19237). So we cannot rely on the latter event, but instead have to do a full update after each `exec_died`, as some of them are the health checks. Also fix the alphabetical sorting of the remaining events.
|
Argh, this makes the health check tests more flaky, especially on ubuntu-2204 (but not limited to that). I analyzed that in #1324 (comment) , reported it as containers/podman#19237 , and documented our accidental workaround explicitly. Now we are back to the status quo of "the test flake a lot", instead of "all the time on ubuntu-2204" 😢 |
martinpitt
changed the title
marusak
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.