Fix testLifecycleOperationsUser restart test, add debug logging #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a debug() API that gets enabled with `window.debugging = "podman"`, similar to how our other Cockpit projects work. Log all REST calls and monitor events.
We hvae to wait until the action menu is actually open for this absence test to be meaningful.
The old "pid changed" waiting loop was completely broken, as the old pid wasn't stripped (thus ending in `\n`), while the new one was. Thus the wait condition was immediately true. Nevertheless, it's not enough to wait for the system state to change, as the UI gets updated asynchronously. The restart events leaked into the following "Force stop" check, and caused unexpected UI changes. There is no steady state change visible in the UI after a restart. Expose the "Pid" and "StartedAt" properties as additional data properties, and use them in the test to wait until the UI actually caught up with the restart. Also, drop the unnecessary no-op filter change, the filter is already set to "All".
Closed
cockpituous
reviewed
Jul 3, 2023
Comment on lines
+17
to
+18
| if (window.debugging === "all" || window.debugging?.includes("podman")) | ||
| console.debug("podman", system ? "system" : "user", ...args); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test. Details
jelly
approved these changes
Jul 3, 2023
|
|
||
| import cockpit from 'cockpit'; | ||
| import { useDialogs } from "dialogs.jsx"; | ||
|
|
||
| import * as client from './client.js'; |
There was a problem hiding this comment.
wondering if eslint can group imports but eh, that's unrelated!
| @@ -1229,6 +1229,7 @@ class TestApplication(testlib.MachineCase): | |||
| if not auth: | |||
| # Check that the checkpoint option is not present for rootless | |||
| b.click(f"#containers-containers tbody tr:contains('{IMG_BUSYBOX}') .pf-v5-c-dropdown__toggle") | |||
| b.wait_visible(self.getContainerAction(IMG_BUSYBOX, 'Force stop')) | |||
There was a problem hiding this comment.
Typo in commit message "hvae" => "have" but fine to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out from PR #1324, as these are ready for landing and already help with debugging. That former PR stress-tests testLifecycleOperationsUser. I still saw a different failure mode of testLifecycleOperationsUser, but the primary one should be fixed now.