Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show toolbox containers different in the containers listing #865

Closed
jelly opened this issue Dec 16, 2021 · 2 comments · Fixed by #1409
Closed

Show toolbox containers different in the containers listing #865

jelly opened this issue Dec 16, 2021 · 2 comments · Fixed by #1409
Labels
enhancement New feature or request

Comments

@jelly
Copy link
Member

jelly commented Dec 16, 2021

For power users who use toolbox and cockpit-podman on their machine, it might be nice to show the toolbox container different in our containers listing before accidentally removing them.

Official toolbox containers have specific labels to identify them as toolbox containers:

[jelle@t14s][~/projects/cockpit]%podman inspect d28e01ad2c37 | jq '.[].Config.Labels'
{
  "architecture": "x86_64",
  "authoritative-source-url": "registry.fedoraproject.org",
  "build-date": "2021-11-02T03:13:49.622981",
  "com.github.containers.toolbox": "true",
  "com.github.debarshiray.toolbox": "true",
  "com.redhat.build-host": "osbs-node02.iad2.fedoraproject.org",
  "com.redhat.component": "fedora-toolbox",
  "distribution-scope": "public",
  "license": "MIT",
  "maintainer": "Debarshi Ray <[email protected]>",
  "name": "fedora-toolbox",
  "release": "12",
  "summary": "Base image for creating Fedora toolbox containers",
  "usage": "This image is meant to be used with the toolbox command",
  "vcs-ref": "c637c4bfa90fb54cee97f7e942174f908857200d",
  "vcs-type": "git",
  "vendor": "Fedora Project",
  "version": "35"
}
@jelly jelly added the enhancement New feature or request label Dec 16, 2021
@jelly
Copy link
Member Author

jelly commented Jul 13, 2022

@garrett I made this issue a while ago, should be do anything with this if not I say we close it.

@garrett
Copy link
Member

garrett commented Jul 20, 2022

It probably makes sense. People using toolbox and Cockpit will likely have other containers and it'd be nice to be able to see which are normal podman containers vs. special toolbox containers.

At a minimum, it'd help us developing Cockpit. 😉

subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 14, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 14, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 15, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 21, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 21, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 21, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 21, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 26, 2023
subhoghoshX added a commit to subhoghoshX/cockpit-podman that referenced this issue Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants