Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pod] Add container to a pod #487

Closed
marusak opened this issue Aug 4, 2020 · 3 comments · Fixed by #867
Closed

[pod] Add container to a pod #487

marusak opened this issue Aug 4, 2020 · 3 comments · Fixed by #867
Labels
enhancement New feature or request has-design

Comments

@marusak
Copy link
Member

marusak commented Aug 4, 2020

See https://raw.githubusercontent.com/cockpit-project/cockpit-design/master/containers/podman-pod-groups.png
#238 (comment)
@marusak marusak added enhancement New feature or request has-design labels Aug 4, 2020
@jelly
Copy link
Member

jelly commented Nov 24, 2021

Adding an existing container to a pod is not supported in podman so that's not something we can implement yet.

@garrett
Copy link
Member

garrett commented Nov 30, 2021

The action is to create a container inside the pod, not add an existing one. I guess the (old) pod mockup says "add container" instead of "create container".

The redesign mockup has "create" in the button and also includes pods:

podman redesign

@jelly
Copy link
Member

jelly commented Dec 15, 2021

The "Create container" modal changes the title to "Create container in $podname"

jelly added a commit to jelly/cockpit-podman that referenced this issue Dec 17, 2021
@jelly
Create a container in a pod
50ac67c 
This adds the ability to create a new container in a pod group, a
container cannot be moved out or into a pod once it has been created.

Closes: cockpit-project#487
@jelly jelly mentioned this issue Dec 17, 2021
Merged
jelly added a commit to jelly/cockpit-podman that referenced this issue Dec 17, 2021
@jelly
Create a container in a pod
3f21a32 
This adds the ability to create a new container in a pod group, a
container cannot be moved out or into a pod once it has been created.

Closes: cockpit-project#487
jelly added a commit that referenced this issue Dec 21, 2021
@jelly
Create a container in a pod
b22f4ae 
This adds the ability to create a new container in a pod group, a
container cannot be moved out or into a pod once it has been created.

Closes: #487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request has-design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a container in a pod jelly/cockpit-podman
3 participants
@garrett @jelly @marusak