packit: Drop targets list from COPR build #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `issue_repository` to tell packit to create issues when propose_downstream/koji/bodhi builds fail. That will provide a convenient place to examine, discuss, and retry them. See https://packit.dev/docs/configuration/#issue_repository and cockpit-project/cockpit-machines#735 (comment)
Hardcoding this list is redundant and hard to change: changing the COPR config and updating all our projects' packit.yml files needs to happen in lockstep. packit now learned to just read the configuration from an existing COPR repository, so drop the target list entirely. See packit/packit-service#1499
marusak
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoding this list is redundant and hard to change: changing the COPR
config and updating all our projects' packit.yml files needs to happen
in lockstep.
packit now learned to just read the configuration from an existing COPR
repository, so drop the target list entirely. See
packit/packit-service#1499
I successfully tested this on my fork, see this conversation ff. -- it needed two rounds, yesterday there was still an error on the packit side.