Makefile: Update Cockpit lib to e3eae5b36d5280c853b3b08e85c0e1ca #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
cockpit-lib-update-cockpit-lib-20240424-052709
branch
from
1b7caf2 to
11a05c6
Compare
|
I triggered this manually to pick up the format_bytes() fix -- I'll drop our manual "B" unit appending, but let's see if the tests even catch this. They should: I expect this to fail with "7 B B" now. It fails as expected in a local run (although in an earlier "0 B" check): It fails the same wy in CI. |
That version fixes `format_bytes()` to show a "B" unit for small numbers, so drop our hack. Closes #396
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20240424-052709
branch
from
11a05c6 to
4634ec3
Compare
jelly
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That version fixes
format_bytes()to show a "B" unit for small numbers, so drop our hack.