Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change powershell.execute to run file in PSIC #52

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Change powershell.execute to run file in PSIC #52

merged 2 commits into from
Jul 18, 2019

Conversation

TylerLeonhardt
Copy link
Collaborator

@TylerLeonhardt TylerLeonhardt commented Jul 16, 2019 •
edited
Loading

resolves #50

Now it will run the file in the PowerShell Integrated Console (PSIC) using &. If there are single quotes in the file path, it will escape those.

@TylerLeonhardt TylerLeonhardt requested review from yatli and corbob July 16, 2019 16:15
@TylerLeonhardt TylerLeonhardt mentioned this pull request Jul 16, 2019
Closed
corbob
corbob approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🎉

@TylerLeonhardt
Copy link
Collaborator Author

Dirty files:
dirty files
Untitled files:
Untitled files

yatli
yatli approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@yatli yatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yatli
Copy link
Member

yatli commented Jul 18, 2019

💯

@yatli yatli merged commit 087ef36 into coc-extensions:master Jul 18, 2019
@mikeTWC1984 mikeTWC1984 mentioned this pull request Jul 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbob corbob corbob approved these changes

@yatli yatli yatli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CocCommand powershell.execute spawns new terminal
3 participants
@TylerLeonhardt @yatli @corbob