-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy the CONTRIBUTING from coc.nvim. #48
Conversation
coc.nvim is MIT licensed, has a reasonable document that covers most of our setup. Changed it slightly to make it more PowerShell heavy.
I probably should have marked this as WIP. I would like to cleanup a bit to make it more coc-powershell centric. |
Change reverences for coc.nvim to coc-powershell
I've updated with the finds from @TylerLeonhardt . One thing that might be helpful is if we could somehow have a docker container to assist with development. Working on the PS Conference Book Volume 2, they've added a dev container that has all of the linting tools and such that can be spun up to do the tests. Would be good if we could get something similar to possibly reduce the barrier to entry for new contributors. Once #49 is merged, perhaps we can build off of it for a development container 🤷♂ |
Looks good. The only feedback is that the |
Also mention we borrowed this from coc.nvim |
Added note about Docker (needs to be fleshed out as we include DockerFile) Removed references to 'conventional changelog format'
Yeah, I saw it, but didn't get to actually looking at it. I understand the reasoning for it, but as you said, we don't seem to care that much about it.
I added a little tongue in cheek note that we shamelessly stole it from coc.nvim. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the comment about the Dockerfile that we can add in once the Dockerfile is ready
clarify steps to run locally remove note about requiring tests, instead indicate that they're encouraged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
coc.nvim is MIT licensed, has a reasonable document that covers most of our setup.
Changed it slightly to make it more PowerShell heavy.
Fixes #45