Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the CONTRIBUTING from coc.nvim. #48

Merged
merged 4 commits into from
Jul 18, 2019

Conversation

corbob
Copy link
Member

@corbob corbob commented Jul 10, 2019

coc.nvim is MIT licensed, has a reasonable document that covers most of our setup.
Changed it slightly to make it more PowerShell heavy.

Fixes #45

coc.nvim is MIT licensed, has a reasonable document that covers most of our setup.
Changed it slightly to make it more PowerShell heavy.
@corbob
Copy link
Member Author

corbob commented Jul 10, 2019

I probably should have marked this as WIP. I would like to cleanup a bit to make it more coc-powershell centric.

Change reverences for coc.nvim to coc-powershell
@corbob corbob requested review from TylerLeonhardt and yatli July 16, 2019 13:11
@corbob
Copy link
Member Author

corbob commented Jul 16, 2019

I've updated with the finds from @TylerLeonhardt .

One thing that might be helpful is if we could somehow have a docker container to assist with development. Working on the PS Conference Book Volume 2, they've added a dev container that has all of the linting tools and such that can be spun up to do the tests. Would be good if we could get something similar to possibly reduce the barrier to entry for new contributors.

Once #49 is merged, perhaps we can build off of it for a development container 🤷‍♂

@TylerLeonhardt
Copy link
Collaborator

Looks good. The only feedback is that the Contribute Code section is a bit strict. Maybe tone down the bullet points? There’s something about comment messages and I don’t think we care that much.

@TylerLeonhardt
Copy link
Collaborator

Also mention we borrowed this from coc.nvim

Added note about Docker (needs to be fleshed out as we include DockerFile)
Removed references to 'conventional changelog format'
@corbob
Copy link
Member Author

corbob commented Jul 17, 2019

Looks good. The only feedback is that the Contribute Code section is a bit strict. Maybe tone down the bullet points? There’s something about comment messages and I don’t think we care that much.

Yeah, I saw it, but didn't get to actually looking at it. I understand the reasoning for it, but as you said, we don't seem to care that much about it.

Also mention we borrowed this from coc.nvim

I added a little tongue in cheek note that we shamelessly stole it from coc.nvim.

Copy link
Collaborator

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the comment about the Dockerfile that we can add in once the Dockerfile is ready

@corbob corbob mentioned this pull request Jul 17, 2019
clarify steps to run locally
remove note about requiring tests, instead indicate that they're encouraged.
Copy link
Member

@yatli yatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt TylerLeonhardt merged commit 96774d2 into coc-extensions:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should have a CONTRIBUTING.md file
3 participants