Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple check #14

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Simple check #14

merged 3 commits into from
Dec 1, 2022

Conversation

kikeztw
Copy link
Contributor

@kikeztw kikeztw commented Dec 1, 2022

1️⃣ Describe the work done

  • User Stories for the following Issues have been completed
  • Bugs have been fixed and tested
  • Issue #:
  • Issue #:

Instructions for QA to validate these issues:

2️⃣ Other PULL REQUESTS (or other dependencies) required to be merged first?

  • ☑️ continue, This PR does NOT require another dependent Pull Request
  • 🛑 break, FIRST merge the following Pull Request:
  • PR #

3️⃣ Code Quality

  • My Code follows Cobuild Lab's Code Conventions
    • I have performed a self-review of my own code
    • I have commented my code, particularly in hard-to-understand areas
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have removed console.log's

4️⃣ Developer Testing

  • ❗️I understand NEW TESTS should be added when adding new features
    • Did Not need to add new test
    • Added these New Tests:
  • I have locally tested the platform thoroughly
    • WEB PROJECTS:
    • Windows: Firefox, Edge, Chrome
    • Mac: Safari
    • Mobile Browsers (iOS/Android) or Chrome Mobile Inspector
  • MOBILE PROJECTS:

  • Tested in Emulators

  • Tested in iOS Device

  • Tested in Android Device

  • I successfully performed the following TESTING

    • Optional: Depending on Project & Environment
    • Functional Testing
    • Smoke Tests in a Development Environment
    • E2E Tests
    • Unit Testing

5. Screenshots

@kikeztw kikeztw merged commit a2b73c1 into main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant