Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog - remove inApp native bars #92

Closed
10 tasks done
ggendre opened this issue Mar 24, 2016 · 6 comments
Closed
10 tasks done

Catalog - remove inApp native bars #92

ggendre opened this issue Mar 24, 2016 · 6 comments

Comments

@ggendre
Copy link
Contributor

ggendre commented Mar 24, 2016

Remove native bars from the native side and use Cobalt nativeBars feature in the whole app.

  • web : remove setTexts and use bars method
  • add a default bars configuration to cobalt.conf
  • remove bars on iOS (except for callback/events pages)
  • remove setTexts on iOS
  • remove bars on Android (except for callback/events pages)
  • remove theme on Android (use default Cobalt.Light one without customization)
  • remove setTexts on Android
  • check everything looks fine
  • merge on develop
  • @ggendre Write an issue about handling default bars configuration in cobalt.conf
@ggendre ggendre self-assigned this Mar 24, 2016
@ggendre ggendre modified the milestone: 0.6 May 26, 2016
@ggendre ggendre added the ready label Jun 9, 2016
@ggendre ggendre removed their assignment Jun 9, 2016
@ggendre ggendre assigned ggendre and unassigned ggendre Jul 15, 2016
@ggendre ggendre added in progress and removed ready labels Jul 15, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Jul 15, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 15, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Jul 15, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Jul 15, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 15, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Jul 15, 2016
@ggendre
Copy link
Contributor Author

ggendre commented Jul 15, 2016

done for the web side. created issue-92 branches on catalog for native parts. assign it back to me when it's done

Doc1faux pushed a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 21, 2016
@Doc1faux Doc1faux removed their assignment Jul 21, 2016
Myrdhinn added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Aug 16, 2016
Myrdhinn added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Aug 16, 2016
@Doc1faux
Copy link
Contributor

Doc1faux commented Oct 5, 2016

Clean Theme for Android apps.
Everything is fine on develop branches.
But for Catalog, issue-92 branches are still existing... @ggendre merge or remove them?

@Doc1faux Doc1faux assigned ggendre and unassigned Myrdhinn Oct 5, 2016
@ggendre
Copy link
Contributor Author

ggendre commented Oct 6, 2016

The idea of this issue was to propose a Catalog app that was using a maximum of cobalt features. So that people know they can easily have the same app without too much headhaches. I'm not totally against the fact that some theming is done on the native side. But we need to document this if we do so. And what about iOS? There is no theming on iOS...

Maybe we can mix both solutions : having the cobalt bars for almost all pages and a special one, plugins for example, themed on native side ?
I think we should use issue-92 as a basis and re-apply some of your theme changes on top of it.

@Doc1faux
Copy link
Contributor

Doc1faux commented Oct 6, 2016

You said it yourself: "people know they can easily have the same app with too much headaches" :P
Without joking, I don't think that's a good idea for the moment to show users that if they want a default theme on Android, they have to define it for each "controller" in cobalt.conf...

I subscribe to your point about the documentation ;)

On iOS, there is no theming definition like on Android.
But like it, you can define one (but in code) only once for the whole app with the UIAppearance class on the application (to investigate).

I would propose the totally opposite ;)
Use native for the default Theme use everywhere in the app except in Dark, NativeBars & Plugins where it is done by the Web.

I have already planned this morning to merge develop in issue-92 to test if Default Themed Value feature/fixes changes has no impact on this.

Doc1faux pushed a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Oct 6, 2016
Doc1faux pushed a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Oct 6, 2016
…n on develop. Update common Web submodule (bar colors & page names). TODO: Default Theme.
Doc1faux pushed a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Oct 6, 2016
…tivity controller and native bars title. Display on 5 toasts in a row, it was so annoying to test with 20...
Doc1faux pushed a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Oct 6, 2016
…, NativeBars & Plugins ones by Web. Other fixes: move raw strings in layouts to strings.xml, optimize/simplify layouts, clear dead code, fix potential crash (actionBar nullability not checked), color resources redefined because not available to lower APIs
Doc1faux pushed a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Oct 6, 2016
…on for iOS10 & fix LocationListener file in project
@Doc1faux
Copy link
Contributor

Doc1faux commented Oct 6, 2016

Move default bars configuration from cobalt.conf to native because, for the moment, it needs to be defined for each controller.
@ggendre Write an issue about this?

@ggendre
Copy link
Contributor Author

ggendre commented Oct 6, 2016

Issue created : [cobalt.conf] better default configuration #129
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants