Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch hang on book list retrieval #75

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Conversation

kashav
Copy link
Member

@kashav kashav commented Apr 29, 2016

Scraper hangs when request response is None.

Stack trace:

Exception in thread Thread-89:
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/Users/kashavmadan/Desktop/cobalt/uoft-scrapers/uoftscrapers/scrapers/textbooks/__init__.py", line 387, in run
    books = Textbooks.retrieve_books(section)
  File "/Users/kashavmadan/Desktop/cobalt/uoft-scrapers/uoftscrapers/scrapers/textbooks/__init__.py", line 229, in retrieve_books
    soup = BeautifulSoup(xml, "html.parser")
  File "/usr/local/lib/python3.5/site-packages/bs4/__init__.py", line 176, in __init__
    elif len(markup) <= 256:
TypeError: object of type 'NoneType' has no len()

@qasim qasim merged commit d05c150 into cobalt-uoft:master Apr 29, 2016
@kashav kashav deleted the textbook-patch branch May 1, 2016 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants