UTEvents #36 #56
UTEvents #36 #56
Conversation
| Scraper.logger.info('Scraped event: %s ' % ( | ||
| doc['id'], | ||
| )) | ||
| with open('%s/%s.json' % (location, doc['id']), 'w') as fp: |
|
Woohoo! Thanks for contributing Hanchen, I really appreciate it. 😅 Will have a look and test this before the end of the day. |
| import json | ||
| import re | ||
|
|
||
| class UTEvents: |
There was a problem hiding this comment.
We can rename this to Events to follow convention (since it is for all 3 campuses, there is no prefix).
|
Oh, @arkon didn't see the helpers. I will change them right away. :V |
| @@ -0,0 +1,126 @@ | |||
| from ..scraper import Scraper | |||
There was a problem hiding this comment.
This should be from ..utils import Scraper
|
|
||
| event_campus = 'Off Campus' | ||
| if evt_bar.select('dd')[0].b != None: | ||
| event_campus = evt_bar.select('dd')[0].b.text |
There was a problem hiding this comment.
event_campus should take on a value of UTSG, UTM, or UTSC depending on the campus (instead of St. George, etc.) to follow convention.
In the case of no campus / off campus, we can just leave event_campus = ''
|
I tested this out further. I left a few more comments and will be glad to merge after they're completed! |
|
@qasim Kay done. ✌️ |
|
Btw I didn't change setup.py and version numbers. |
|
That's fine, we'll release a new version sometime next week. Thanks again for contributing :) |
Well that was fun.
Am I part of the cool kids now?