Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated lifecycle hooks with new one. Add support for angular component with string paramters #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as angular from 'angular'
import kebabCase = require('lodash.kebabcase')
import { $injector as defaultInjector } from 'ngimport'
import * as React from 'react'
import { $injector as defaultInjector } from 'ngimport'

interface Scope<Props> extends angular.IScope {
props: Props
Expand Down Expand Up @@ -39,16 +39,15 @@ export function angular2react<Props extends object>(
$injector = defaultInjector
): React.ComponentClass<Props> {

return class extends React.Component<Props, State<Props>> {
return class Component extends React.Component<Props, State<Props>> {

state: State<Props> = {
didInitialCompile: false
didInitialCompile: false,
scope: Object.assign(this.getInjector().get('$rootScope').$new(true), { props: writable(this.props) }),
}

componentWillMount() {
this.setState({
scope: Object.assign($injector.get('$rootScope').$new(true), { props: writable(this.props) })
})
getInjector() {
return $injector || angular.element(document.querySelectorAll('[ng-app]')[0]).injector();
}

componentWillUnmount() {
Expand All @@ -64,10 +63,15 @@ export function angular2react<Props extends object>(

// called only once to set up DOM, after componentWillMount
render() {
const bindings: {[key: string]: string} = {}
const bindings: { [key: string]: string } = {}
if (component.bindings) {
for (const binding in component.bindings) {
bindings[kebabCase(binding)] = `props.${binding}`
if (component.bindings[binding].includes('@')) {
// @ts-ignore
bindings[kebabCase(binding)] = this.props[binding];
} else {
bindings[kebabCase(binding)] = `props.${binding}`;
}
}
}
return React.createElement(kebabCase(componentName),
Expand All @@ -77,29 +81,32 @@ export function angular2react<Props extends object>(

// makes angular aware of changed props
// if we're not inside a digest cycle, kicks off a digest cycle before setting.
componentWillReceiveProps(props: Props) {
if (!this.state.scope) {
return
static getDerivedStateFromProps(props: Props, state: State<Props>) {
if (!state.scope) {
return null
}
this.state.scope.props = writable(props)
this.digest()
state.scope.props = writable(props)
Component.digest(state.scope)

return {...state};
}

private compile(element: HTMLElement) {
if (this.state.didInitialCompile || !this.state.scope) {
return
}

const $injector = this.getInjector();
$injector.get('$compile')(element)(this.state.scope)
this.digest()
Component.digest(this.state.scope)
this.setState({ didInitialCompile: true })
}

private digest() {
if (!this.state.scope) {
static digest(scope: Scope<Props>) {
if (!scope) {
return
}
try { this.state.scope.$digest() } catch (e) { }
try {scope.$digest() } catch (e) { }
}

}
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular2react",
"version": "3.0.2",
"version": "6.0.0",
"description": "One line of code to turn any Angular 1 Component into a React Component",
"main": "index.js",
"main:esnext": "index.es2015.js",
Expand Down Expand Up @@ -69,10 +69,10 @@
},
"peerDependencies": {
"@types/angular": ">=1.5.0",
"@types/react": ">=15.0.0",
"@types/react-dom": ">=15.0.0",
"@types/react": ">=17.0.0",
"@types/react-dom": ">=17.0.0",
"angular": ">=1.5.0",
"react": ">=15.0.0",
"react-dom": ">=15.0.0"
"react": ">=17.0.0",
"react-dom": ">=17.0.0"
}
}