Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lru-cache dependency, update Node versions in CI #374

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Nov 19, 2023

Spin-off from #373 that upgrades the lru-cache, because it is a bit tedious to debug otherwise.

Also updates the Node versions used by the CI, since the most recent lru-cache version seems to be incompatible with Node 14. Since Node 14 is EOL by way, applying this update might be overdue anyway.

Copy link

Pull Request Test Coverage Report for Build 6920889522

  • 12 of 14 (85.71%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.757%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/server.ts 12 14 85.71%
Files with Coverage Reduction New Missed Lines %
lib/server.ts 3 86.75%
Totals Coverage Status
Change from base Build 5048002328: -0.1%
Covered Lines: 2857
Relevant Lines: 3072

💛 - Coveralls

Copy link

github-actions bot commented Nov 19, 2023

Pull Request Test Coverage Report for Build 6941605775

  • 13 of 14 (92.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 91.871%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/server.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 5048002328: -0.02%
Covered Lines: 2861
Relevant Lines: 3072

💛 - Coveralls

@JKRhb JKRhb force-pushed the update-lru branch 3 times, most recently from 293357a to 3bfc369 Compare November 19, 2023 16:01
@JKRhb JKRhb force-pushed the update-lru branch 2 times, most recently from a19aaac to b9dcb6f Compare November 19, 2023 22:25
@JKRhb JKRhb changed the title chore: update lru-cache dependency chore: update lru-cache dependency, update Node versions in CI Nov 19, 2023
@JKRhb JKRhb marked this pull request as ready for review November 19, 2023 22:27
@JKRhb JKRhb requested a review from Apollon77 November 19, 2023 22:27
Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al right ... makes sense, BUT you also need to change https://github.com/coapjs/node-coap/blob/master/package.json#L68 !

@JKRhb
Copy link
Member Author

JKRhb commented Nov 21, 2023

Al right ... makes sense, BUT you also need to change https://github.com/coapjs/node-coap/blob/master/package.json#L68 !

Thank you, good catch! :) I now set the minimum version to 18, by the way, as I remembered that 16 was phased out early due to the EOL of OpenSSL 1.1.1

@JKRhb
Copy link
Member Author

JKRhb commented Nov 21, 2023

If the current changes still work for you, then you could just hit the merge button :)

@Apollon77 Apollon77 merged commit 289f852 into master Nov 21, 2023
7 checks passed
@JKRhb JKRhb deleted the update-lru branch November 21, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants