Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace nyc with c8 for code coverage #338

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Apr 23, 2022

Having a look at coveralls.io, I noticed that code coverage seems to be a bit broken right now. I recently found a better tool than nyc called c8 that seems to work with V8's native code coverage capabilities and be used as a drop-in replacement, fixing typescript related issues with nyc. It also gets rid of one additional dev-dependency.

@JKRhb JKRhb requested a review from Apollon77 April 23, 2022 16:27
@coveralls
Copy link

coveralls commented Apr 23, 2022

Pull Request Test Coverage Report for Build 2212862587

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 97 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+7.3%) to 94.556%

Files with Coverage Reduction New Missed Lines %
lib/outgoing_message.ts 1 97.92%
index.ts 2 93.43%
lib/helpers.ts 2 97.07%
lib/observe_read_stream.ts 2 92.21%
lib/observe_write_stream.ts 2 95.1%
lib/cache.ts 3 92.0%
lib/segmentation.ts 3 89.58%
lib/option_converter.ts 4 94.39%
lib/middlewares.ts 5 87.4%
lib/agent.ts 28 87.13%
Totals Coverage Status
Change from base Build 2201295132: 7.3%
Covered Lines: 8660
Relevant Lines: 9060

💛 - Coveralls

@JKRhb
Copy link
Member Author

JKRhb commented Apr 23, 2022

Oh, as you can see the improvement above already :) nyc wasn't capable of handling typescript, as it seems.

@Apollon77 Apollon77 merged commit a1e25a0 into coapjs:master Apr 23, 2022
@JKRhb JKRhb deleted the coverage-improvement branch April 23, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants