Add traverse-with-path
#1300
Open
Add traverse-with-path
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks pretty good. I wonder if there is a more elegant way to handle multiple wrapping actions. The current traversal code treats an action-list almost like an alist so that defaults can be overridden, but this PR makes it clear that it could also be nice to use an action-list like an actual sequence of commands.
src/codegen/traverse.lisp
Outdated
Comment on lines
278
to
283
| (let ((r (apply (action-function action) | ||
| node | ||
| path-thunk | ||
| args))) | ||
| (pop traversal-path) | ||
| r))))) |
There was a problem hiding this comment.
I think you could also just prog1 this
src/codegen/traverse.lisp
Outdated
| (make-action when 'node | ||
| (lambda (node &rest _rest) | ||
| (declare (ignore rest)) | ||
| (funcall op node)))))) |
There was a problem hiding this comment.
Wait, what is op? Is this supposed to be a copy of the ecase above, just with the (apply (action-function action) node path-thunk args) removed?
There was a problem hiding this comment.
Good catch. Remnant of the previous version.
It is a variation of `traverse`, except the actions receives a `path-thunk` argument after the visiting node. When called within the action, `path-thunk` returns a list of ascendant nodes of the visiting node, i.e. its car is the immediate parent, and its the last element is the root node on which `traverse-with-path` is called. This is useful for AST walker that needs wider context surrounding the node of concern.
shirok
force-pushed
the
traverse-with-path
branch
from
730198c to
5e19de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a variation of
traverse, except the actions receives apath-thunkargument after the visiting node. When called within the action,path-thunkreturns a list of ascendant nodes of the visiting node, i.e. its car is the immediate parent, and its the last element is the root node on whichtraverse-with-pathis called.This is useful for AST walker that needs wider context surrounding the node of concern.
This PR supersedes #1291. This one avoid relying on special variables.