Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiling to coalton-library/system #1299

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add profiling to coalton-library/system #1299

merged 1 commit into from
Oct 10, 2024

Conversation

Izaakwltn
Copy link
Collaborator

This adds a profiling interface (besides just Time) for Coalton.

Copy link
Collaborator

@jbouwman jbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Izaakwltn Izaakwltn enabled auto-merge (rebase) October 10, 2024 20:14
@Izaakwltn Izaakwltn merged commit 194c079 into main Oct 10, 2024
33 checks passed
@Izaakwltn Izaakwltn deleted the add-profiling branch October 10, 2024 20:16
Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditionals were a mistake.

@@ -8,6 +8,12 @@
#:time
#:sleep)
(:export
#:get-real-time
#:get-run-time
#+sbcl #:get-bytes-consed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be exported by all implementations but maybe return None

(lisp UFix ()
(cl:get-internal-real-time)))

#+sbcl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not do this in the standard library

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't happen again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants