-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiling to coalton-library/system #1299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
3c5e964
to
2af0f3b
Compare
2af0f3b
to
48231f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conditionals were a mistake.
@@ -8,6 +8,12 @@ | |||
#:time | |||
#:sleep) | |||
(:export | |||
#:get-real-time | |||
#:get-run-time | |||
#+sbcl #:get-bytes-consed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be exported by all implementations but maybe return None
(lisp UFix () | ||
(cl:get-internal-real-time))) | ||
|
||
#+sbcl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not do this in the standard library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't happen again
This adds a profiling interface (besides just Time) for Coalton.