Generic error printer and stream access #1066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbouwman
force-pushed
the
source-error
branch
3 times, most recently
from
b278815 to
0dc789e
Compare
jbouwman
pushed a commit
to jbouwman/coalton
that referenced
this pull request
Mar 13, 2024
Modify parser-tests to check the literal contents of emitted parser errors. Provides verification for modifications of error printer in coalton-lang#1066
eliaslfox
pushed a commit
that referenced
this pull request
Mar 15, 2024
Modify parser-tests to check the literal contents of emitted parser errors. Provides verification for modifications of error printer in #1066
jbouwman
force-pushed
the
source-error
branch
2 times, most recently
from
6f9890e to
88b5364
Compare
This change set moves non-coalton-specific error printing from src/error.lisp into src/source-error.lisp. The monolithic output function is rewritten as a `printer-state` object and associated output functions. - Merge source-error value object and source-error condition classes - Unthread 'file' argument to parser functions
|
suspended until there is interest in working on error ergonomics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move error printing from src/error.lisp to src/source-error.lisp, and make it independent of Coalton.
fileargument when constructing errors; instead, bind a source file, or string, at compiler entry.coalton-errorstructure into condition classes.display-coalton-errorinto smaller functions.