.coafile: Added .md file extension #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 75b9af90-d7a1-11e8-9c01-d7c60254052a |
stellargo
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
Ah well see you are adding all .md files to be checked by SpaceConsistencyBear. Your next step should be looking into what this bear does, how it would affect any .md files present in the repo. You should try running this bear locally on your machine and using the bear itself to resolve the issues :)
And also look into https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html#how-to-write-good-commit-messages for writing a better commit message :)
Man-Jain
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
The changes you made applies the SpaceConsistencyBear on the md files also. So now you have to run coala on your local machine and it will suggest some changes to be done on the md files. After doing these changes the Travis will be green again.
You'll also need to change your commit mesaage but that can be left for now.
Also make sure you don't open a new PR make changes to this PR only. All the best 😃 👍
utkarsh2102
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
Hey,
Besides the changes that are requested, your commit doesn't have a commit message.
Please write one as per the guidelines.
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: a3728f10-d7b0-11e8-9c01-d7c60254052a |
There was a problem hiding this comment.
Thanks for working on this @SerekKiri 😄
The code LGTM. There's a problem in your commit message. You've mentioned something like This commit fixed issue. Instead it should be Closes. Please refer to this article to properly edit the commit message as required.
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: c83ee3d0-d7b4-11e8-9c01-d7c60254052a |
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 4250aad0-d7b7-11e8-9c01-d7c60254052a |
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: a9a5a680-d7b8-11e8-9c01-d7c60254052a |
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 886d5bb0-d7b9-11e8-9c01-d7c60254052a |
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 3e806190-d7ba-11e8-9c01-d7c60254052a |
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 43abd130-d7bb-11e8-9c01-d7c60254052a |
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1.ci/build.shdocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 2e438300-d7bc-11e8-9c01-d7c60254052a |
stellargo
suggested changes
Oct 24, 2018
|
Correct typo ussles --> useless |
SerekKiri
force-pushed
the
master
branch
3 times, most recently
from
4ff4e23 to
3c02d17
Compare
Travis tests have failedHey @SerekKiri, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 42f98c60-d864-11e8-b9f2-b1fbc111596d |
SerekKiri
force-pushed
the
master
branch
3 times, most recently
from
957706f to
7e21ebe
Compare
ishanSrt
suggested changes
Oct 25, 2018
|
@ishanSrt We decide on gitter that here it will be two commits |
jayvdb
requested changes
Oct 25, 2018
| @@ -93,12 +93,12 @@ difficult to debug things like: | |||
| E AssertionError: 0 == 0 : The local bear 'CheckstyleBear' yields no result although it should. | |||
| E Running bear CheckstyleBear... | |||
| E Running 'java -jar /home/ubuntu/.local/share/coala-bears/CheckstyleBear/checkstyle.jar -c /home/ubuntu/ | |||
| .local/share/coala-bears/CheckstyleBear/google.xml /home/ubuntu/coala-bears/tests/java/test_files/ | |||
| CheckstyleGood.java' | |||
| .local/share/coala-bears/CheckstyleBear/google.xml /home/ubuntu/coala-bears/tests/java/test_files/ | |||
There was a problem hiding this comment.
Not modified yet. You need to add two more spaces here.
| .local/share/coala-bears/CheckstyleBear/google.xml /home/ubuntu/coala-bears/tests/java/test_files/ | ||
| CheckstyleGood.java' | ||
| .local/share/coala-bears/CheckstyleBear/google.xml /home/ubuntu/coala-bears/tests/java/test_files/ | ||
| CheckstyleGood.java' |
|
Ok my bad 😅 then please change the body of the most recent commit |
Changes after executing the SpaceConsistency Bear. Closes coala#529
jayvdb
approved these changes
Oct 25, 2018
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add markdown files extension to whitespace consistency rule
Closed issue: #529