-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result reporter tool #555
Comments
There is also the LSP diagnostics format, which has been worked on at https://github.com/coala/coala-vs-code/blob/6648e76/coala_langserver/diagnostic.py |
We have a new repo for it https://gitlab.com/coala/coala-json |
@jayvdb Is this project proposal explicitly for GSOC, or can we work and complete it outside of it? |
See
There is at least one projet in this, maybe two. And lots of little related bugs and improvements that are available for anyone to work on. |
do we need to develop plugins for each CI and each format mentioned in the project? |
@jayvdb @li-boxuan Since CI tools will help us in reporting tests and failures, and in that case time factor plays a vital role so won't it be good if we add |
Yes we can add that, and many other result reporter tool as mentioned in
example , too shows execution time
…On Tue, 19 Mar 2019, 11:28 am Keshav Garg, ***@***.***> wrote:
@jayvdb <https://github.com/jayvdb> @li-boxuan
<https://github.com/li-boxuan> Since CI tools will help us in reporting
tests and failures, and in that case *time factor* plays a vital role so
won't it be good if we add execution time for each section in the coala
output results?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#555 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcS9h66cGg4gztpO4Xj0OxW-oXfqWSwmks5vYHycgaJpZM4TYGAI>
.
|
This sounds like a plan. You can also mention that in your proposal 👍 |
If we observe all the given test result formats carefully then we can find many such attributes that we can add to coala result and thus we can change our coala result probably the one last time before the final mapping to various test results. |
Yes @chay2199 I've been already analyzing all such attributes that can help us. |
@li-boxuan |
@li-boxuan as we need to create tool which convert json to junit format but also there are existing tool present which can do so cant we integrate them only or make them only to support coala? |
Be specific. Which tool? You can write down in your draft proposal with examples and why you believe they can solve our problem. |
okay I am writing down that in my draft proposal and will submit for review today only or at max tomorrow |
@li-boxuan i used csv to json converter like this in my project. Although this may sound silly do we need to use already available tools like this but its dependency is Also, jenkins
But these may not serve the purpose i think we need to develop the tool our self using the above open sourced available tools. |
@Dhiraj240 r u going to submit the proposal for this idea? |
Yes.I am not getting gut feeling for my |
It's not a good idea. First, it's a node package instead of a python package. Second, it might be out of date. Third, it does not have tests. Last, it is not very complex, so why not write a python version?
Yes. Please also read #704 (review)
This has been answered in #704 |
The coala json format provides a stable output.
There are other formats which are useful for reporting tests and failures.
Most commonly used is JUnit format. (which isnt really a specified format; see https://blog.ilias.xyz/unit-test-output-formats-a-state-of-affairs-5734b4c8e577)
Converting the static analysis results into a test results format has been done a few times, such as early PEP8 plugins to Jenkins. The mapping isnt exact, but the benefits of using the test result format is tight integration with various system.
CircleCI can accept this format: https://circleci.com/docs/2.0/collect-test-data/
AppVeyor can receive a test results XML format, in the format output by xunit, presumably the same as JUnit.
https://www.appveyor.com/docs/running-tests/#uploading-xml-test-results
The first project phase could involve converting the JSON to JUnit format and uploading into Circle CI and Appveyor.
The JUnit format should also be tested with a Jenkins install, to ensure it is uploading correctly there. This would mean our Jenkins project is much less important.
Another common format is TAP.
And there is Clover XML format.
Then there are some system, such as Phabricator, which have a custom format they expect.
c.f. facebook/infer#673
The above probably doesnt fill 3 months.
Pulling the coala results from CI using this format could be a way to inform newbies of the style problems with their PRs.
Another way to expand this project is to also push the unit test results as XML to the CI (using combination XML files if necessary)
The text was updated successfully, but these errors were encountered: