Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cobot_enhancement.md: URLs are not encoded correctly #308

Closed
coala-bot opened this issue Jun 1, 2017 · 8 comments
Closed

cobot_enhancement.md: URLs are not encoded correctly #308

coala-bot opened this issue Jun 1, 2017 · 8 comments

Comments

@coala-bot
Copy link

The links are not links, and as a result _ in the URLs are rendered as italics.
cc @meetmangukiya
difficulty/newcomer

Opened via gitter by @jayvdb

@AnishHota
Copy link
Member

Hey, i am a newbie. Haven't yet contributed to open source project. I will like to take this issue. But all the links on the cobot_enhancement.md works fine. Could you please leaborate the issue so that i can contribute. Thank you.

@ghost
Copy link

ghost commented Jun 10, 2017

All the links in cobot_enhancement.md works fine. The _ in URLs is rendered as italics because that is the format of how it should appear in a text editor if we want to add an inline link in a markdown file. Example: [text to display](the actual link). The difference is not noticed in other links of the file because there are only two inline link in the whole markdown file in the format given above. The other link does not show the same characteristic because it is not written in the correct format as there is a line break between the words inside [] between hubot and framework. Thus it works in the same way but doesn't show up the same way in text editor.

@shivakrishna9
Copy link
Member

shivakrishna9 commented Jul 9, 2017

As the '_' is causing the above behavior, I want to change the _ to a '-' . @meetmangukiya Is this a right approach?

Eg: cobot_enhancement to cobot-enhancement and then convert to [text to display](the actual link) format.

@jayvdb
Copy link
Member

jayvdb commented Jul 9, 2017

@shivakrishna9 , you want to rename the files? are there other cases of _ which would also need renames?

@shivakrishna9
Copy link
Member

@shivakrishna9 , you want to rename the files?

@jayvdb Yes. I hope no new problems will arise with the change. Many orgs are using this convention.

are there other cases of _ which would also need renames?

Yes. Some files in other folders are also named with '_'s. They may cause the same behaviour later on. Can I go ahead and change the filenames and refactor the code accordingly.

@shivakrishna9
Copy link
Member

@jayvdb @meetarora29 Ping ;)

@jayvdb
Copy link
Member

jayvdb commented Mar 18, 2018

@shivakrishna9 , yes, you can rename them. Even better, add a rule to .coafile to prevent _ being used in markdown filenames.

@haeungun
Copy link
Contributor

@jayvdb I am take a look in this issue ~!!

rahuldkjain pushed a commit to rahuldkjain/projects that referenced this issue Oct 11, 2018
- Update the md files name which were
  snake case style to be the kebab style.
- Update .coafile to check whether a name of
  md files are the kebab style.

Closes coala#308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants