Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Travis CI #247

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Add Travis CI #247

merged 1 commit into from
Nov 19, 2017

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Nov 18, 2017 •
edited
Loading

Closes #248

@jayvdb jayvdb mentioned this pull request Nov 18, 2017
Open
@jayvdb jayvdb force-pushed the travis branch 5 times, most recently from 3c4cd0f to a82abb7 Compare November 18, 2017 07:05
@jayvdb jayvdb changed the title Add Netlify and Travis CI Add Travis CI Nov 18, 2017
@Makman2
Copy link
Member

Makman2 commented Nov 18, 2017

Commit message:
Currently reads like the commit wants to check coala itself ;)
Probably Add Travis CI checking with coala is better ;)

@jayvdb
Add Travis CI checking with coala
c9ded40 
Remove checking of whitespace for JavaScript,
as there are large numbers of errors.
Ignore more vendor and generated files
so that coala-ci is green.

Closes coala#248
yashovardhan
yashovardhan reviewed Nov 19, 2017
View reviewed changes
Copy link
Member

@yashovardhan yashovardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack c9ded40

@jayvdb
Copy link
Member Author

jayvdb commented Nov 19, 2017

@rultor merge

@rultor
Copy link

rultor commented Nov 19, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c9ded40 into coala:master Nov 19, 2017
@rultor
Copy link

rultor commented Nov 19, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashovardhan yashovardhan yashovardhan approved these changes

Assignees
No one assigned
Labels
process/pending review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayvdb @Makman2 @rultor @yashovardhan