Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PULL_REQUEST_TEMPLATE.md: cobot --> corobo #533

Merged
merged 1 commit into from
Mar 10, 2018
Merged

PULL_REQUEST_TEMPLATE.md: cobot --> corobo #533

merged 1 commit into from
Mar 10, 2018

Conversation

nguptaa183
Copy link
Member

@nguptaa183 nguptaa183 commented Feb 15, 2018 •
edited
Loading

PULL_REQUEST_TEMPLATE.md: cobot --> corobo

Closes #503

@nguptaa183 nguptaa183 changed the title Changes PULL_REQUEST_TEMPLATE.md: Changed cobot to corob Feb 15, 2018
Vedarth
Vedarth suggested changes Feb 15, 2018
View reviewed changes
Copy link
Member

@Vedarth Vedarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly remove .swp file. Also please squash your commits.

Vedarth
Vedarth suggested changes Feb 15, 2018
View reviewed changes
Copy link
Member

@Vedarth Vedarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advice you to read the newcomers guidelines page on documentation as well.

@nguptaa183 nguptaa183 closed this Feb 15, 2018
@Makman2
Copy link
Member

Makman2 commented Feb 15, 2018

Please don't close PRs if your commits are not ready yet, you can always fix them up in the same PR.

@Makman2 Makman2 reopened this Feb 15, 2018
@Makman2
Copy link
Member

Makman2 commented Feb 15, 2018

Please fix your commits up here.

@nguptaa183
Copy link
Member Author

@Makman2 Sorry I tried but couldn't figure it out. That's why I closed the PR, deleted repo and cloned the repo once again.

@Makman2
Copy link
Member

Makman2 commented Feb 15, 2018

Sorry I tried but couldn't figure it out. That's why I closed the PR, deleted repo and cloned the repo once again.

That's bad, please never do again :) Please read up our docs, it describes how to fix up your PRs.

@nguptaa183
Copy link
Member Author

Sure @Makman2 This won't repeat again :)

@nguptaa183 nguptaa183 changed the title PULL_REQUEST_TEMPLATE.md: Changed cobot to corob Correct typo error: cobot --> corobo Feb 15, 2018
Makman2
Makman2 reviewed Feb 16, 2018
View reviewed changes
PULL_REQUEST_TEMPLATE.md Outdated

Please take a quick look at those things down there. They're quite important.
Really! We wrote them for you. Yes you! With utmost care. Read them.
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of the issue.

@Makman2
Copy link
Member

Makman2 commented Feb 16, 2018

Please read our commit message guidelines. Also you should clean up your commit body ;)

@Makman2
Copy link
Member

Makman2 commented Feb 16, 2018

unack a05640f

@sangamcse
Copy link
Member

Use git commit --amend to edit commit message.

@ishanSrt
Copy link

You have written the same sentence twice in commit body. No need for that.
Second this is not a typo. Typos are mistakes while typing while this is due to the death of cobot and birth of corobo

@ishanSrt
Copy link

ishanSrt commented Feb 17, 2018 •
edited
Loading

So change your shortlog and body to a better description of what you are doing, also full stop missing in commit body

@nguptaa183 nguptaa183 changed the title Correct typo error: cobot --> corobo Changes: cobot --> corobo Feb 17, 2018
Vedarth
Vedarth suggested changes Feb 17, 2018
View reviewed changes
Copy link
Member

@Vedarth Vedarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nguptaa When you write git commit --amend and get to the stage of writing the commit message the first line is reserved for shortlog or heading of the commit message. You need to write the 'heading' of the commit skip a line and then write the body of commit which will contain the description of your commit. After that again skip a line and write Closes https://github.com/coala/documentation/issues/503
That is all you need to do. 😉

@sangamcse
Copy link
Member

Why is gitmate not catching the commit issue??

@ishanSrt
Copy link

Redundant commit body.

Vedarth
Vedarth suggested changes Feb 17, 2018
View reviewed changes
Copy link
Member

@Vedarth Vedarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly describe your commit in commit body. Please read commit guidelines as well https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

@ishanSrt
Copy link

@Vedarth the commit is perfectly fine. Please go through the link you have provided again if you are missing something 👍

ishanSrt
ishanSrt reviewed Feb 17, 2018
View reviewed changes
PULL_REQUEST_TEMPLATE.md Outdated
Please take a quick look at those things down there. They're quite important.
Really! We wrote them for you. Yes you! With utmost care. Read them.
-->

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this deletion? is that specified in the issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. But after i changed cobot-->corobo this automatically got added.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not possible

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe your branch is behind coala master

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync your branch with coala master

@sangamcse
Copy link
Member

sangamcse commented Feb 17, 2018 •
edited
Loading

You need to squash your commit. Use git reset --hard 09233f25e619230758c033040cff911277178a95 and then git commit --amend to write commit message. After that git push -f.

@sangamcse
Copy link
Member

Now, whenever you do changes on a PR, first do changes in file and then use git add . and then git commit --amend. After that git push -f.

@nguptaa183
Copy link
Member Author

@sangamcse Thanks, I will follow it :)

@Makman2
Copy link
Member

Makman2 commented Feb 17, 2018

ack b5e8961

@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated rebase with GitMate.io was successful! 🎉

@jayvdb jayvdb changed the title Changes: cobot --> corobo PULL_REQUEST_TEMPLATE.md: cobot --> corobo Mar 10, 2018
@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

reack 6002139

@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit 6002139 into coala:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishanSrt ishanSrt ishanSrt left review comments

@Makman2 Makman2 Makman2 left review comments

@Vedarth Vedarth Vedarth requested changes

Assignees

@nguptaa183 nguptaa183

Labels
difficulty/newcomer process/approved size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nguptaa183 @Makman2 @sangamcse @ishanSrt @jayvdb @gitmate-bot @Vedarth