Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The example in coala as git pre-commit hook should not have $ sign #538

Closed
Mariatta opened this issue Feb 22, 2018 · 1 comment
Closed

The example in coala as git pre-commit hook should not have $ sign #538

Mariatta opened this issue Feb 22, 2018 · 1 comment
Assignees
@Mariatta
Labels
area/documentation difficulty/newcomer importance/high

Comments

@Mariatta
Copy link
Member

In http://docs.coala.io/en/latest/Users/coala_as_Git_Hook.html#pre-commit-hooks, the example file:

$ #!/bin/sh
$ set -e
$ coala

The $ in front of each lines should be removed.
Mariatta added a commit that referenced this issue Feb 22, 2018
@Mariatta
Update pre-commit hook example
dcda80a 
Remove the $ sign from the beginning of each line in the .git/hooks/pre-commit file example.

Fixes #538
@Mariatta Mariatta mentioned this issue Feb 22, 2018
Merged
@Makman2
Copy link
Member

Makman2 commented Feb 22, 2018

Yeah this is bad...

@Mariatta Mariatta self-assigned this Feb 22, 2018
Mariatta added a commit that referenced this issue Feb 23, 2018
@Mariatta
coala_as_Git_Hook.rst: Remove the $ sign from the code example
b54313b 
Remove the `$` sign from the beginning of each line in the
.git/hooks/pre-commit file example.
The `$` sign was not needed.

Closes #538
Mariatta added a commit that referenced this issue Feb 23, 2018
@Mariatta
coala_as_Git_Hook.rst: Remove the $ sign from
90703b1 
Remove the `$` sign from the beginning of each
line in the .git/hooks/pre-commit file example.
The `$` sign was not needed.

Closes #538
Mariatta added a commit to Mariatta/documentation that referenced this issue Feb 25, 2018
@Mariatta
coala_as_Git_Hook.rst: Remove the $ sign.
1a20690 
Remove the `$` sign from the beginning of each
line in the .git/hooks/pre-commit file example.
The `$` sign was not needed.

Closes coala#538
Mariatta added a commit that referenced this issue Feb 26, 2018
@Mariatta
coala_as_Git_Hook.rst: Remove the $ sign
10fbb4e 
Remove the `$` sign from the beginning of each
line in the .git/hooks/pre-commit file example.
The `$` sign was not needed.

Closes #538
Naveenaidu pushed a commit to Naveenaidu/documentation that referenced this issue Mar 4, 2018
@Mariatta @Naveenaidu
coala_as_Git_Hook.rst: Remove the $ sign
152b1b1 
Remove the `$` sign from the beginning of each
line in the .git/hooks/pre-commit file example.
The `$` sign was not needed.

Closes coala#538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mariatta Mariatta

Labels
area/documentation difficulty/newcomer importance/high
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mariatta @Makman2 @gitmate-bot