Add default PR description

[Adrianzatreanu]

From @AbdealiJK on June 23, 2016 4:6

I was submitting a patch at scikit-image and I was really impressed with their default PR message:

## Description
[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]


## Checklist
[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]
- [ ] Clean style in [the spirit of PEP8](https://www.python.org/dev/peps/pep-0008/)
- [ ] [Docstrings for all functions](https://github.com/numpy/numpy/blob/master/doc/example.py)
- [ ] Gallery example in `./doc/examples` (new features only)
- [ ] Unit tests

[For detailed information on these and other aspects see [scikit-image contribution guidelines](http://scikit-image.org/docs/dev/contribute.html)]


## References
[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

The checklist is really nice and serves as a better reminder of "things to do" as compared to writing it in a documentation.

Copied from original issue: coala/coala#2389

[Adrianzatreanu]

From @gitmate-bot on June 23, 2016 4:6

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

[Adrianzatreanu]

From @AbdealiJK on June 23, 2016 4:7

You can find their other templates and this one at https://github.com/scikit-image/scikit-image/tree/master/.github

[Adrianzatreanu]

From @hypothesist on July 2, 2016 15:58

We could also add something about doctests. Also modify the first check point to something like "Run coala on the project before submitting" as that should pretty much cover any code standards issue. (We could also convince scikit-image devs to use coala.)

[dotgourav]

Do you have some content in mind for this?

[sils]

We should probably have a link to coala.io/commit at least, explain people that they should do rebases and stuff like this. Also mention that people should get assigned to an issue when wanting to work on it.

Btw. @gouravchawla I sent you a community invitation so I can assign you - would you be interested in fixing this? Actually I think this can save us a hell lot of time.

[dotgourav]

Yes, I would love to work on it. @sils1297

[adtac]

@gouravchawla assigned you 👍

[dotgourav]

I apologize for the delay but here is what I came up with based on the scikit's PR template. I welcome suggestions on its improvement.

PR Template:

Description

[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

• Clean style in the spirit of PEP8
• Docstrings for all functions
• Commit messages that follow the instructions given here
• Tests

[For detailed information on these and other aspects see contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]

[underyx]

As far as I know, you can use comments in markdown, so instead of

[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]

we could have

<!-- Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images. -->

which doesn't need to be deleted/replaced by the reporter.

[dotgourav]

Ok, i'll turn that into comments. The checklist would still need to be removed though, isn't it?

[Adrianzatreanu]

is this still needed?

[sils]

yes we should ideally replace the gitmate autoresponse with good PR templates everywhere Sincerely, Lasse Schuirmann [email protected] http://coala.io/ - http://viperdev.io/ - http://gitmate.com/

…

On 2 February 2017 at 18:27, Zatreanu Adrian-Gabriel < ***@***.***> wrote: is this still needed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFc6KEzXfmi8cfkucjxh6a6lilJhiG_sks5rYhIHgaJpZM4JoZaB> .

[jayvdb]

Moved to coala/meta#117