labhub.py: Add error message when nick is empty #642

abhishalya · 2018-11-02T19:17:05Z

All of the backends do not have nick attribute.
Hence an error will be shown whenever nick is empty.

Closes #632

Reviewers Checklist

Appropriate logging is done.
Appropriate error responses.
Handle every possible exception.
Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
See that 100% coverage is there.
See to it that mocking is not done where it is not necessary.

TravisBuddy · 2018-11-02T19:33:48Z

Hey @abhishalya,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 3756e790-ded6-11e8-9517-3f3b7d8cc1c8

plugins/labhub.py

abhishalya · 2018-11-02T19:54:47Z

I apologize for not checking the code locally. WIll not push until checked :)

nvzard

You'll also need to write tests along with cleaning up the code :)

abhishalya · 2018-11-03T07:28:13Z

@nvzard Sure, is this the correct approach though? Do I need to make any changes in the statements?

plugins/labhub.py

abhishalya · 2018-11-05T13:27:04Z

Ping @nvzard @meetmangukiya

tests/labhub_test.py

abhishalya · 2018-11-06T07:47:37Z

Btw InvalidLinkBear is complaining:

plugins/ship_it.py
|  14| ········'http://i.imgur.com/DPVM1.png',
|    | [NORMAL] InvalidLinkBear:
|    | Broken link - unable to connect to http://i.imgur.com/DPVM1.png (HTTP Error: 404)

meetmangukiya

We have to test if the error messages are being sent whenever the nick is not available. Create a new test function test_empty_nick where you create a message that has an empty nick, and make errbot use that mocked empty nick(am not sure how you can do this. Maybe @nvzard knows?).

Also, you are involved with both @jayvdb and @nvzard, so if they suggested something different, go with that.

plugins/labhub.py

tests/labhub_test.py

plugins/labhub.py

tests/labhub_test.py

All of the backends do not have `nick` attribute. Hence an error will be shown whenever nick is empty. Closes coala#632

nvzard

Good Work 👍

jayvdb · 2018-11-06T15:40:13Z

ack 4c61393

jayvdb · 2018-11-06T15:40:20Z

@gitmate-bot ff

gitmate-bot · 2018-11-06T15:40:24Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-11-06T15:41:16Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/XS backend/zulip difficulty/low importance/high initiatives/gci labels Nov 2, 2018

gitmate-bot assigned abhishalya Nov 2, 2018

abhishalya force-pushed the nickEmptyError branch from 70334a3 to c0f0a89 Compare November 2, 2018 19:47

gitmate-bot reviewed Nov 2, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

gitmate-bot reviewed Nov 2, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

gitmate-bot reviewed Nov 2, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

gitmate-bot reviewed Nov 2, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

gitmate-bot reviewed Nov 2, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

gitmate-bot reviewed Nov 2, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

nvzard suggested changes Nov 3, 2018

View reviewed changes

abhishalya force-pushed the nickEmptyError branch from c0f0a89 to 5323328 Compare November 3, 2018 07:44

jayvdb requested changes Nov 3, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

plugins/labhub.py Outdated Show resolved Hide resolved

jayvdb added process/wip and removed process/pending review labels Nov 3, 2018

nvzard suggested changes Nov 3, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

abhishalya force-pushed the nickEmptyError branch from 5323328 to c790b15 Compare November 5, 2018 11:21

gitmate-bot added process/pending review and removed process/wip labels Nov 5, 2018

nvzard suggested changes Nov 5, 2018

View reviewed changes

tests/labhub_test.py Outdated Show resolved Hide resolved

jayvdb requested changes Nov 6, 2018

View reviewed changes

tests/labhub_test.py Outdated Show resolved Hide resolved

abhishalya force-pushed the nickEmptyError branch from c790b15 to 2c02447 Compare November 6, 2018 07:45

meetmangukiya requested changes Nov 6, 2018

View reviewed changes

plugins/labhub.py Outdated Show resolved Hide resolved

tests/labhub_test.py Outdated Show resolved Hide resolved

tests/labhub_test.py Outdated Show resolved Hide resolved

tests/labhub_test.py Outdated Show resolved Hide resolved

jayvdb requested changes Nov 6, 2018

View reviewed changes

tests/labhub_test.py Outdated Show resolved Hide resolved

abhishalya force-pushed the nickEmptyError branch 2 times, most recently from 1125087 to 9b2e2c7 Compare November 6, 2018 09:45

nvzard suggested changes Nov 6, 2018

View reviewed changes

plugins/labhub.py Show resolved Hide resolved

abhishalya force-pushed the nickEmptyError branch from 9b2e2c7 to 0e36cab Compare November 6, 2018 13:20

nvzard reviewed Nov 6, 2018

View reviewed changes

tests/labhub_test.py Outdated Show resolved Hide resolved

abhishalya force-pushed the nickEmptyError branch from 0e36cab to 4860ff6 Compare November 6, 2018 14:37

labhub.py: Add error message when nick is empty

4c61393

All of the backends do not have `nick` attribute. Hence an error will be shown whenever nick is empty. Closes coala#632

abhishalya force-pushed the nickEmptyError branch from 4860ff6 to 4c61393 Compare November 6, 2018 15:20

nvzard approved these changes Nov 6, 2018

View reviewed changes

jayvdb approved these changes Nov 6, 2018

View reviewed changes

gitmate-bot added process/approved and removed process/pending review labels Nov 6, 2018

gitmate-bot merged commit 4c61393 into coala:master Nov 6, 2018

gitmate-bot removed the process/approved label Nov 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

labhub.py: Add error message when nick is empty #642

labhub.py: Add error message when nick is empty #642

abhishalya commented Nov 2, 2018 •

edited

Loading

TravisBuddy commented Nov 2, 2018

abhishalya commented Nov 2, 2018

nvzard left a comment

abhishalya commented Nov 3, 2018

abhishalya commented Nov 5, 2018

abhishalya commented Nov 6, 2018 •

edited

Loading

meetmangukiya left a comment

nvzard left a comment

jayvdb commented Nov 6, 2018

jayvdb commented Nov 6, 2018

gitmate-bot commented Nov 6, 2018

gitmate-bot commented Nov 6, 2018

labhub.py: Add error message when nick is empty #642

labhub.py: Add error message when nick is empty #642

Conversation

abhishalya commented Nov 2, 2018 • edited Loading

Reviewers Checklist

TravisBuddy commented Nov 2, 2018

TravisBuddy Request Identifier: 3756e790-ded6-11e8-9517-3f3b7d8cc1c8

abhishalya commented Nov 2, 2018

nvzard left a comment

Choose a reason for hiding this comment

abhishalya commented Nov 3, 2018

abhishalya commented Nov 5, 2018

abhishalya commented Nov 6, 2018 • edited Loading

meetmangukiya left a comment

Choose a reason for hiding this comment

nvzard left a comment

Choose a reason for hiding this comment

jayvdb commented Nov 6, 2018

jayvdb commented Nov 6, 2018

gitmate-bot commented Nov 6, 2018

gitmate-bot commented Nov 6, 2018

abhishalya commented Nov 2, 2018 •

edited

Loading

abhishalya commented Nov 6, 2018 •

edited

Loading