Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use activate instead of __init__ for LabHub plugins #554

Closed
nvzard opened this issue Jun 9, 2018 · 1 comment
Closed

Use activate instead of __init__ for LabHub plugins #554

nvzard opened this issue Jun 9, 2018 · 1 comment
Labels
area/labhub enhancement

Comments

@nvzard
Copy link
Member

nvzard commented Jun 9, 2018

No description provided.

@jayvdb jayvdb changed the title [GSoC '18] Use activate instead of __init__ for LabHub plugins Use activate instead of __init__ for LabHub plugins Jun 16, 2018
@jayvdb
Copy link
Member

jayvdb commented Jun 16, 2018

We have many issues which are effectively about this, allowing the plugin to start without automatically logging into with the tokens and fetching everything.

See #357 and #253 and others in labhub label.

All of those require removing the __init__ and using the correct plugin startup sequence. IMO this issue will be automatically fixed during one of those.
Just fixing __init__ -> activate is ignoring the elephant in the room, and is code churn.

nvzard added a commit to nvzard/corobo that referenced this issue Jul 4, 2018
@nvzard
LabHub: Use activate instead of init
492a529 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Closes coala#554
@nvzard nvzard mentioned this issue Jul 4, 2018
Merged
nvzard added a commit to nvzard/corobo that referenced this issue Jul 16, 2018
@nvzard
LabHub: Use activate instead of init
5804c5c 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Closes coala#554
nvzard added a commit to nvzard/corobo that referenced this issue Aug 2, 2018
@nvzard
LabHub: Use activate instead of init
c783ebe 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Closes coala#554
nvzard added a commit to nvzard/corobo that referenced this issue Aug 3, 2018
@nvzard
LabHub: Use activate and configuration templates
4fc0d95 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 3, 2018
@nvzard
LabHub: Use activate and configuration templates
a1a1886 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 3, 2018
@nvzard
LabHub: Use activate and configuration templates
e70b745 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 3, 2018
@nvzard
LabHub: Use activate and configuration templates
6673cc4 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 4, 2018
@nvzard
LabHub: Use activate and configuration templates
38e124d 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 4, 2018
@nvzard
LabHub: Use activate and configuration templates
bc5ce03 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 5, 2018
@nvzard
LabHub: Use activate and configuration templates
236f6f3 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 5, 2018
@nvzard
LabHub: Use activate and configuration templates
178487d 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 5, 2018
@nvzard
LabHub: Use activate and configuration templates
f256eea 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 8, 2018
@nvzard
LabHub: Use activate and configuration templates
2fa1296 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 8, 2018
@nvzard
LabHub: Use activate and configuration templates
5aed609 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
nvzard added a commit to nvzard/corobo that referenced this issue Aug 9, 2018
@nvzard
LabHub: Use activate and configuration templates
826ffaa 
__init__ is executed at load time and
and any issue in the plugin will lead
to it not showing up.
LifeCycle: __init__->configured->enable

Adapts to the `DefaultConfigMixin` and
migrated to using configuration templates.

Closes coala#554
Closes coala#382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/labhub enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @gitmate-bot @nvzard