Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to set the GitHub username #255

Open
co-robo opened this issue Aug 9, 2017 · 5 comments
Open

Find a way to set the GitHub username #255

co-robo opened this issue Aug 9, 2017 · 5 comments

Comments

@co-robo
Copy link

co-robo commented Aug 9, 2017

LabHub assumes the username is always a GitHub username, while this works for gitter. It doesn't work for other platforms such as Telegram, IRC, etc
Opened by @yukiisbored at gitter//yukiisbored

@jayvdb
Copy link
Member

jayvdb commented Sep 14, 2017

There is a similar problem for issues on GitLab repos, which ideally should mention a GitLab username instead of a GitHub username.

The GitLab issue also appears for the web-frontend with https://gitlab.com/coala/landing/issues/31

Ultimately, we need a database. IMO, we should use a gspread or bitrix24 as the datastore.

@jayvdb
Copy link
Member

jayvdb commented Nov 20, 2017

And we also have this problem with Zulip, which is based on email addresses.

One approach is to have a 'github username' method, which each backend service implements to convert what it has, to a github username.

For the Zulip backend, it is easy to do an email address lookup via the GitHub API.

@yukiisbored
Copy link
Member

yukiisbored commented Nov 21, 2017

@jayvdb Personally, using spreadsheet services is more of a hack rather than an actual solution for databases. Since this is essentially a key-value situation, something like Redis (or an even more permanent) solution would be preferable rather than a fully blown spreadsheet application for such athing.

@yukiisbored
Copy link
Member

yukiisbored commented Nov 21, 2017

Most services will at least tell you what their email is. If corobo fails or the service simply doesn't have that luxury, we can just simply ask the person to set it manually.

For example:

<corobo> Hello, We've been trying to find your GitHub/GitLab account since it's needed for a lot of core features of corobo. To enable GitHub/GitLab related integrations, please tell me your GitHub/GitLab account by doing `corobo set github your_github_username` and `corobo set gitlab your_gitlab_username`
<someguy1> corobo set github someguy21
<corobo> someguy1: I've set your GitHub account to someguy21! :tada:

@jayvdb jayvdb self-assigned this Nov 27, 2017
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

Fixes coala#392
Related to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

Fixes coala#392
Related to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

Fixes coala#392
Related to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

Fixes coala#392
Related to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

Fixes coala#392
Related to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

Fixes coala#392
Related to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

ixes coala#392
elated to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

ixes coala#392
elated to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

ixes coala#392
elated to coala#255
jayvdb added a commit to jayvdb/corobo that referenced this issue Nov 29, 2017
Some backends do not provide usernames or msg links.

Zulip and Slack both using msg.extra['url'], and a
patch is pending for the gitter backend to follow suite.
errbotio/err-backend-gitter#32

Fixes coala#392
Related to coala#255
@Makman2
Copy link
Member

Makman2 commented Nov 30, 2017

Maybe we also add some crosslink command for linking accounts into a single "corobo-account-entity"? (that bases on github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants