explain.py: Recognize beginning and end of string

Add ^ and $ to the regex so the command is not triggered from anywhere in the capture string Closes #364
coala · Nov 27, 2017 · 340bf99 · 340bf99
1 parent 35587aa
commit 340bf99
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/plugins/explain.py b/plugins/explain.py
@@ -90,7 +90,7 @@ class Explain(BotPlugin):
         '\n- '.join(MSGS.keys())
     )
 
-    @re_botcmd(pattern=r'explain\s+(\w+)(?:\s+to\s+@?([\w-]+))?',
+    @re_botcmd(pattern=r'^explain\s+(\w+)(?:\s+to\s+@?([\w-]+))?$',
                re_cmd_name_help='explain <term>',
                flags=re.IGNORECASE)
     def explain(self, msg, match):

diff --git a/tests/explain_test.py b/tests/explain_test.py
@@ -19,3 +19,5 @@ def test_explain(testbot):
                           text.convert(Explain.ERROR_MSG))
     testbot.assertCommand("!explain review to @meet",
                           '@meet')
+    testbot.assertCommand("!please explain review",
+                          "Command \"please\" / \"please explain\" not found.")