Import IGitt Data #100
Merged
Import IGitt Data #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, this needs to model |
|
You need to be looking at what data you need from GitHub which isnt modelled in |
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
jayvdb
reviewed
Mar 21, 2018
community/settings.py
Outdated
| @@ -36,6 +36,7 @@ | |||
| 'gci', | |||
| 'gsoc', | |||
| 'data', | |||
| 'org', | |||
There was a problem hiding this comment.
As I already explained at #102 (comment) , 'org' != git. It also doesnt equal IGitt.
For more about 'org', see new issue #113
gitmate-bot
reviewed
Mar 23, 2018
repos/tests.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| from django.test import TestCase | |||
There was a problem hiding this comment.
'django.test.TestCase' imported but unused
Origin: PyFlakesBear, Section: all.python.default.
gitmate-bot
reviewed
Mar 23, 2018
repos/views.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| from django.shortcuts import render | |||
There was a problem hiding this comment.
'django.shortcuts.render' imported but unused
Origin: PyFlakesBear, Section: all.python.default.
gitmate-bot
reviewed
Mar 23, 2018
repos/admin.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| from django.contrib import admin | |||
There was a problem hiding this comment.
'django.contrib.admin' imported but unused
Origin: PyFlakesBear, Section: all.python.default.
gitmate-bot
reviewed
Jul 4, 2018
data/issues.py
Outdated
| from data.newcomers import get_newcomers | ||
| from data.models import Contributor | ||
| from data.web import web_url | ||
| from community.git import get_org_name |
There was a problem hiding this comment.
'community.git.get_org_name' imported but unused
Origin: PyFlakesBear, Section: all.python.default.
Travis tests have failedHey @sks444, 2nd Buildcoala --non-interactive -V |
|
@sks444 commit messages are not clear.Go through the down mentioned link to learn how to write a good commit. |
jayvdb
reviewed
Jul 19, 2018
data/issues.py
Outdated
| elif hoster == 'gitlab': | ||
| IMPORT_URL = web_url + 'issues/github/all' | ||
| else: | ||
| IMPORT_URL = 'https://pastebin.com/raw/X9a6D5ym' |
There was a problem hiding this comment.
what is this dataset? 'test'? if so, the else: should be elif hoster == 'test':
and add a comment about this
| IMPORT_DATA = staticmethod(import_issue) | ||
|
|
||
| def handle(self, *args, **options): | ||
| # for data in self.COLLECTIONS('github'): |
There was a problem hiding this comment.
just checking .. these are commented because they dont work?
data/web.py
Outdated
| from community.git import get_org_name | ||
|
|
||
|
|
||
| def web_url(): |
There was a problem hiding this comment.
this is not "web". it is "webservices"
and refer to the get_upstream_remote_url discussion on li-boxuan 's patch
jayvdb
reviewed
Jul 19, 2018
data/issues.py
Outdated
| :return: a json of issues data | ||
| """ | ||
| logger = logging.getLogger(__name__) | ||
| if hoster == 'github': |
There was a problem hiding this comment.
also comments at https://github.com/coala/community/pull/160/files#r200812800
|
Comment on 35b4538, file openhub/data.py, line 20. Broken link - unable to connect to https://www.openhub.net/orgs/ Origin: InvalidLinkBear, Section: |
Travis tests have failedHey @sks444, 2nd Buildcoala --non-interactive -V |
jayvdb
requested changes
Aug 1, 2018
data/models.py
Outdated
| def __str__(self): | ||
| return str(self.number) | ||
|
|
||
| def get_issue_for_issue_number(self): |
There was a problem hiding this comment.
_for_issue_number is redundant as the context is an IssueNumber
data/tests/test_models.py
Outdated
|
|
||
| def test_get_issue_for_issue_number(self): | ||
| issue_number = IssueNumber.objects.get(number=1) | ||
| issue = Issue.objects.get(number=1) |
There was a problem hiding this comment.
need a real test of a real MR in real repo, which is merged and closed an issue
I cant see which repo this refers to
|
Comment on 8db229d, file twitter/view_twitter.py, line 20. Broken link - unable to connect to https://gci-leaders.netlify.com/data.json Origin: InvalidLinkBear, Section: |
|
Comment on 8db229d, file community/settings.py, line 130. Broken link - unable to connect to https://docs.djangoproject.com/en/1.11/howto/static-files/ Origin: InvalidLinkBear, Section: |
This create models for issues and mrs and import related data for the same from the webservices. Closes #83
jayvdb
approved these changes
Aug 2, 2018
|
|
||
| # Expected closes issue objects list | ||
| issue_objects_list = [ | ||
| Issue.objects.get(number=57, repo_id=52889504), |
There was a problem hiding this comment.
repo_id=52889504 in tests is confusing - should mention coala-quickstart.
also repo_id numbers could clash between github and gitlab, so this entire thing is probably buggy, but whatever .. we'll cross that bridge when we get there.
|
ack 537602e |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
first two commits is from #138