gsoc: Gemfile info extraction #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
||
| @property | ||
| def value(self): | ||
| return self._value |
There was a problem hiding this comment.
usually we use _x and make x as property because we have a x.setter modifying the _x, I wonder why are you using it this way :/ ?
There was a problem hiding this comment.
Agreed. The reasoning for me was if in future we want to have different internal representation and different output representation, then we just need to make changes just in the getter function.
| """ | ||
| Return extracted information (if any) | ||
| """ | ||
| return self._information |
adtac
requested changes
Jun 25, 2017
| from coala_quickstart.info_extraction.Info import Info | ||
|
|
||
|
|
||
| class VersionInfo(Info): |
There was a problem hiding this comment.
So this will kinda conflict with the other PRs right? If you want stuff merged in a particular order, lemme know.
| ProjectDependencyInfo, VersionInfo) | ||
|
|
||
|
|
||
| class GemfileInfoExtractor(InfoExtractor): |
There was a problem hiding this comment.
Again, a gemfile spec (official or unofficial) would be awesome
Adds a class attribute named spec_references which contains links to the issues/documentations for relevant specs of supported files. Related to #126
Adds a class attribute named example_values illustrating sample information values that are allowed to be stored inside the Info class. Closes #125
Adds Info classes relevant to extractors of package.json and other meta-files. Related to #100
Adds ``PackageJSONInfoExtractor`` class to extract relevant information from package.json file. Closes #100
Adds extractor class ``GemfileInfoExtractor`` to extract relevant information from Gemfile. Related to #119
adtac
approved these changes
Jun 26, 2017
|
ack d23329a |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.