-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use existing paths in Gruntfile.js #42
Comments
@jayvdb Just wanted to check if I understood it correctly. We've to do the following things
I discovered that in addition to
Also I came across another kind of usage that involves
IMO we should look for the above patterns as well and also take care of the sub-keys like |
That sounds very sensible. Re "Try to map the discovered sub-task to a coala-bear, if failed, warn the users." , IMO a "warning" isnt really required, and the focus should be to inform the users what parts of the Gruntfile.js were detected and enabled, and maybe a small note that -quickstart didnt recognise other parts of the Gruntfile.js , without too much detail or alarm. |
@jayvdb Sorry to ping you again. I just had some doubts regarding:
|
@satwikkansal , either approach can work. either
re mapping tasks to bears, again both of your suggested approaches sound like they could work well. Be bold. Try everything. Dont worry about performance. If it works, 👍 , and someone can rewrite it later if a better implementation comes along. |
@satwikkansal , can you check whether the libraries you are using have:
If not, it would be a good idea to try to do those things upstream, which hopefully doesnt result in any surprises, but ... if there are surprises you'll want to know about them now, not in phase 3 ;-) #22 will need to be merged before your larger features are merged, otherwise the quality of your solution is unknown, and the bug reports will pour in during Google Code-In from Windows users if there are problems, catching us unprepared. |
For JS related files I've been using
I'll create upstream issues regarding both of them. |
Alright, I had appveyor in later phases, but will now adapt my timeline accordingly :) |
Completed with a more organized approach as a part of my GSoC project (relevant commits shown above), closing it now :) |
Gruntfile.js contains pre-existing configuration which will exist in mature projects, which can be used to create the correct
.coafile
configuration. e.g. https://github.com/wikimedia/jquery.imeThose top level keys (csslint, jscs, jshint) are constant, and directly map to names of linters; but the sub-keys change per grunt plugin, but
all
andmain
are quite common. IMO quickstart should still find all relevant files, and then emit a message to say which relevant files have been excluded due toGruntfile.js
.There is also a common, but not standard, excerpt to correctly choose necessary linters:
It would be very nice to warn if any of the
lint
sub-tasks can not be mapped to a bear in coala.The text was updated successfully, but these errors were encountered: