Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project management: Cask, tests and CI #17

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

fleimgruber
Copy link
Contributor

Use the cask library for project management. Use ert for tests.
Adds an exemplary test for the PEP8Bear. CI is also part of project
management.

Closes #11

@fleimgruber
Copy link
Contributor Author

fleimgruber commented Jun 8, 2017

Note: The combination of .coafile and the :command in flycheck-coala.el works only for the provided simple test in coala-test.el. I do have a fix for this interaction, but would like to open a separate PR for it. I shot this PR first just so that we have a CI baseline established for further changes - Travis results here. WDYT?

@sils
Copy link
Member

sils commented Jul 15, 2017

yep we can do it incremental, I guess this is better than nothing anyway right?

README.md Outdated
@@ -1,5 +1,6 @@
Flycheck coala Checker
======================
[![Build Status](https://travis-ci.org/fleimgruber/coala-emacs.svg?branch=master)](https://travis-ci.org/fleimgruber/coala-emacs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/fleimgruber/coala/

bears = GitCommitBear

[python]
bears = PEP8Bear
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

it looks like you're missing a railing newline before the end of the file here. This article has more information about this issue.

(depends-on "dash")
(depends-on "flycheck")
(depends-on "f")
(depends-on "ert-runner"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

it looks like you're missing a railing newline before the end of the file here. This article has more information about this issue.

@sils
Copy link
Member

sils commented Jul 15, 2017

I don't understand the tests but if you say they work proper they're most likey an improvement to before ;) So other than those pointed out things I think this is ready to go, I'll enable travis for this repo now.

@sils
Copy link
Member

sils commented Jul 20, 2017

@fleimgruber can you squash your commits together? Use git rebase -i master and select fixup on the second commit

@sils
Copy link
Member

sils commented Jul 20, 2017

otherwise fine, let's squash and merge this, it's about time

Use the ``cask`` library for project management.  Use ``ert`` for tests.
Adds an exemplary test for the PEP8Bear.  CI is also part of project
management.

Closes coala#11
@fleimgruber
Copy link
Contributor Author

@sils thanks for review, squashed.

@sils
Copy link
Member

sils commented Jul 20, 2017

ack 64cadb4

@sils
Copy link
Member

sils commented Jul 20, 2017

@rultor merge

@rultor
Copy link

rultor commented Jul 20, 2017

@rultor merge

@sils OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 64cadb4 into coala:master Jul 20, 2017
@rultor
Copy link

rultor commented Jul 20, 2017

@rultor merge

@sils Done! FYI, the full log is here (took me 2min)

@fleimgruber fleimgruber deleted the cask_and_testing branch July 22, 2017 18:44
This was referenced Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants