-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project management: Cask, tests and CI #17
Conversation
Note: The combination of |
yep we can do it incremental, I guess this is better than nothing anyway right? |
README.md
Outdated
@@ -1,5 +1,6 @@ | |||
Flycheck coala Checker | |||
====================== | |||
[![Build Status](https://travis-ci.org/fleimgruber/coala-emacs.svg?branch=master)](https://travis-ci.org/fleimgruber/coala-emacs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/fleimgruber/coala/
bears = GitCommitBear | ||
|
||
[python] | ||
bears = PEP8Bear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
it looks like you're missing a railing newline before the end of the file here. This article has more information about this issue.
(depends-on "dash") | ||
(depends-on "flycheck") | ||
(depends-on "f") | ||
(depends-on "ert-runner")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
it looks like you're missing a railing newline before the end of the file here. This article has more information about this issue.
I don't understand the tests but if you say they work proper they're most likey an improvement to before ;) So other than those pointed out things I think this is ready to go, I'll enable travis for this repo now. |
@fleimgruber can you squash your commits together? Use |
otherwise fine, let's squash and merge this, it's about time |
Use the ``cask`` library for project management. Use ``ert`` for tests. Adds an exemplary test for the PEP8Bear. CI is also part of project management. Closes coala#11
79c43f9
to
64cadb4
Compare
@sils thanks for review, squashed. |
ack 64cadb4 |
@rultor merge |
Use the
cask
library for project management. Useert
for tests.Adds an exemplary test for the PEP8Bear. CI is also part of project
management.
Closes #11