checkstyle #992

sils · 2016-11-14T10:40:42Z

No description provided.

sils · 2016-11-14T10:40:52Z

not fully tested yet

gitmate-bot · 2016-11-14T10:40:58Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
- I have followed the guidelines for the commit shortlog.
- I have followed the guidelines for the commit body.
- I have included the issue URL.
- I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

gitmate-bot · 2016-11-14T10:41:20Z

bears/general/QuotesBear.py

+
+    def run(self, filename, file, dependency_results,
+            preferred_quotation: str='"'):
+        if isinstance(dependency_results[AnnotationBear.name][0].contents, str):


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-14T10:41:21Z

bears/general/QuotesBear.py

+            diff.change_line(sourcerange.start.line,
+                             file[sourcerange.start.line - 1],
+                             replacement)
+            yield Result(self, "Your quotation sucks!", diff.affected_code(filename), diffs={filename: diff})


Line is longer than allowed. (109 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-14T10:41:22Z

bears/general/QuotesBear.py

+        before = file[sourcerange.start.line - 1][:sourcerange.start.column-1]
+        after = file[sourcerange.start.line - 1][sourcerange.end.column:]
+
+        replacement = before + preferred_quotation + str_contents + preferred_quotation + after


Line is longer than allowed. (95 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-14T10:41:22Z

bears/general/QuotesBear.py

+        before = file[sourcerange.start.line - 1][:sourcerange.start.column-1]
+        after = file[sourcerange.start.line - 1][sourcerange.end.column:]
+
+        replacement = before + preferred_quotation + str_contents + preferred_quotation + after


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/general/QuotesBear.py +++ b/bears/general/QuotesBear.py @@ -20,7 +20,8 @@ before = file[sourcerange.start.line - 1][:sourcerange.start.column-1] after = file[sourcerange.start.line - 1][sourcerange.end.column:] - replacement = before + preferred_quotation + str_contents + preferred_quotation + after + replacement = before + preferred_quotation + \ + str_contents + preferred_quotation + after if replacement != file[sourcerange.start.line - 1]: diff = Diff(file) diff.change_line(sourcerange.start.line,

gitmate-bot · 2016-11-14T14:19:50Z

bears/general/QuotesBear.py

+        :param preferred_quotation: Your preferred quotation character, e.g.
+                                    ``"`` or ``'``.
+        """
+        if isinstance(dependency_results[AnnotationBear.name][0].contents, str):


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2016-11-14T14:29:42Z

bears/general/QuotesBear.py

+        if not isinstance(dependency_results[AnnotationBear.name][0],
+                          HiddenResult):
+            return
+        if isinstance(dependency_results[AnnotationBear.name][0].contents, str):


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

abhay-raizada · 2016-11-14T15:06:22Z

ack fac086e hope it still works :P

nemani · 2016-11-14T15:03:51Z

bears/general/AnnotationBear.py

-                                a tuple of SourceRanges of comments
-                                respectively.
+        :param language:
+            Language to be whose annotations are to be searched.


Doesn't make complete sense, Incorrect grammer?

filed a newcomer issue, this is just reformatted and not changed. #994

nemani · 2016-11-14T15:05:39Z

bears/general/QuotesBear.py

+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting'}
+


ASCIINEMA ?

I was too lazy and they make good newcomer issues :P

sils · 2016-11-15T11:03:40Z

reack a4dd7a2

gitmate-bot · 2016-11-15T17:36:19Z

bears/java/JavaPMDBear.py

@@ -94,4 +94,5 @@ def create_arguments(filename, file, config_file,
            "java-unusedcode": not allow_unused_code}
        rules = ','.join(key for key in options if options[key])

-        return which("run.sh"), "pmd", "-R", rules, "-d", filename
+        executable = which("pmd") or which("run.sh")  # On mac it'll be PMD e.g.


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/java/JavaPMDBear.py +++ b/bears/java/JavaPMDBear.py @@ -94,5 +94,6 @@ "java-unusedcode": not allow_unused_code} rules = ','.join(key for key in options if options[key]) - executable = which("pmd") or which("run.sh") # On mac it'll be PMD e.g. + # On mac it'll be PMD e.g. + executable = which("pmd") or which("run.sh") return executable, "pmd", "-R", rules, "-d", filename

gitmate-bot · 2016-11-15T17:36:19Z

bears/java/JavaPMDBear.py

@@ -94,4 +94,5 @@ def create_arguments(filename, file, config_file,
            "java-unusedcode": not allow_unused_code}
        rules = ','.join(key for key in options if options[key])

-        return which("run.sh"), "pmd", "-R", rules, "-d", filename
+        executable = which("pmd") or which("run.sh")  # On mac it'll be PMD e.g.


Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section linelength.

Adrianzatreanu · 2016-11-17T10:06:01Z

bears/java/CheckstyleBear.py

-            "checkstyle.jar")
+            'http://sourceforge.net/projects/checkstyle/files/checkstyle/7.2'
+            '/checkstyle-7.2-all.jar',
+            "checkstyle-7-2.jar")


these still dont fix it .. ?

seems not :/

sils · 2016-11-17T10:20:56Z

@Adrianzatreanu can you debug this on windows?

jayvdb · 2016-11-19T00:30:46Z

bears/java/CheckstyleBear.py

-    "google": "https://raw.githubusercontent.com/checkstyle/checkstyle/master/src/main/resources/google_checks.xml",
-    "sun": 'https://raw.githubusercontent.com/checkstyle/checkstyle/master/src/main/resources/sun_checks.xml',
+    "google": "https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-7.2/src/main/resources/google_checks.xml",
+    "sun": 'https://raw.githubusercontent.com/checkstyle/checkstyle/master/src/checkstyle-7.2/resources/sun_checks.xml',


master/src/checkstyle-7.2 ??

-> checkstyle-7.2/src/main ?

jayvdb · 2016-11-19T00:31:55Z

unack 3820ffe

sils · 2016-11-19T00:40:22Z

yeah, not fixing it yet :/

Those file may have been updated

sils · 2016-11-19T11:35:25Z

@Makman2 can you test run this on windows?

jayvdb · 2016-11-21T16:35:40Z

I believe this is the bug you encountered, and are fixing: Checkstyle with style google fails with CheckstyleException ?

sils · 2016-11-22T11:36:53Z

@jayvdb had a way better fix

jayvdb · 2016-11-22T12:28:41Z

Bumping the version to 7.2 would still be useful.

gitmate-bot added the process/pending review label Nov 14, 2016

gitmate-bot added the size/M label Nov 14, 2016

gitmate-bot reviewed Nov 14, 2016

View reviewed changes

sils force-pushed the sils/quotation branch from d792aae to c45992a Compare November 14, 2016 14:19

gitmate-bot added size/L and removed size/M labels Nov 14, 2016

gitmate-bot reviewed Nov 14, 2016

View reviewed changes

sils force-pushed the sils/quotation branch from c45992a to 2166d0d Compare November 14, 2016 14:29

gitmate-bot added size/XXL review carefully! and removed size/L labels Nov 14, 2016

gitmate-bot reviewed Nov 14, 2016

View reviewed changes

sils force-pushed the sils/quotation branch from 2166d0d to e0f55f6 Compare November 14, 2016 14:30

sils mentioned this pull request Nov 14, 2016

add documentation how to use the annontation bear as a dependency coala/documentation#272

Open

sils force-pushed the sils/quotation branch from e0f55f6 to f9e1adf Compare November 14, 2016 15:01

gitmate-bot added size/L and removed size/XXL labels Nov 14, 2016

nemani reviewed Nov 14, 2016

View reviewed changes

sils force-pushed the sils/quotation branch from f9e1adf to b9ed523 Compare November 15, 2016 11:03

sils force-pushed the sils/quotation branch from b9ed523 to 7518a38 Compare November 15, 2016 11:31

gitmate-bot reviewed Nov 15, 2016

View reviewed changes

sils force-pushed the sils/quotation branch from 82ec85d to 0ab4d7e Compare November 15, 2016 17:47

gitmate-bot added size/L and removed size/XL labels Nov 16, 2016

sils force-pushed the sils/quotation branch 2 times, most recently from af58a7b to 3820ffe Compare November 17, 2016 09:30

sils changed the title ~~Sils/quotation~~ checkstyle Nov 17, 2016

gitmate-bot added size/XS and removed size/L labels Nov 17, 2016

Adrianzatreanu reviewed Nov 17, 2016

View reviewed changes

gitmate-bot added size/S and removed size/XS labels Nov 17, 2016

jayvdb reviewed Nov 19, 2016

View reviewed changes

CheckstyleBear: Upgrade checkstyle

4f05d7d

sils force-pushed the sils/quotation branch from 2ae1f5a to 4f05d7d Compare November 19, 2016 00:33

gitmate-bot added size/XS and removed size/S labels Nov 19, 2016

AppVeyor: Remove bears download caching

a1c5875

Those file may have been updated

gitmate-bot added size/S and removed size/XS labels Nov 19, 2016

sils added process/wip and removed process/pending review labels Nov 19, 2016

Makman2 self-assigned this Nov 21, 2016

sils closed this Nov 22, 2016

sils deleted the sils/quotation branch November 22, 2016 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

checkstyle #992

checkstyle #992

sils commented Nov 14, 2016

sils commented Nov 14, 2016

gitmate-bot commented Nov 14, 2016

gitmate-bot Nov 14, 2016

gitmate-bot Nov 14, 2016

gitmate-bot Nov 14, 2016

gitmate-bot Nov 14, 2016

gitmate-bot Nov 14, 2016

gitmate-bot Nov 14, 2016

abhay-raizada commented Nov 14, 2016

nemani Nov 14, 2016

sils Nov 14, 2016

nemani Nov 14, 2016

sils Nov 14, 2016

sils commented Nov 15, 2016

gitmate-bot Nov 15, 2016

gitmate-bot Nov 15, 2016

Adrianzatreanu Nov 17, 2016

sils Nov 17, 2016

sils commented Nov 17, 2016

jayvdb Nov 19, 2016

jayvdb commented Nov 19, 2016

sils commented Nov 19, 2016

sils commented Nov 19, 2016

jayvdb commented Nov 21, 2016

sils commented Nov 22, 2016

jayvdb commented Nov 22, 2016

checkstyle #992

checkstyle #992

Conversation

sils commented Nov 14, 2016

sils commented Nov 14, 2016

gitmate-bot commented Nov 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhay-raizada commented Nov 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Nov 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Nov 17, 2016

Choose a reason for hiding this comment

jayvdb commented Nov 19, 2016

sils commented Nov 19, 2016

sils commented Nov 19, 2016

jayvdb commented Nov 21, 2016

sils commented Nov 22, 2016

jayvdb commented Nov 22, 2016