Bug solving sprint #747

AbdealiLoKo · 2016-08-31T15:33:53Z

No description provided.

Adrianzatreanu · 2016-08-31T15:36:36Z

bears/js/JSHintBear.py

@@ -209,6 +209,14 @@ def generate_config(filename, file,
        :param use_mozilla_extension:
            This options tells JSHint that your code uses Mozilla JavaScript
            extensions.
+        :param javascript_strictness:
+            What sort of strictness to use in the javascript code. The


javascript -> JavaScript

AsnelChristian · 2016-08-31T16:39:26Z

bears/js/JSHintBear.py

@@ -209,6 +209,14 @@ def generate_config(filename, file,
        :param use_mozilla_extension:
            This options tells JSHint that your code uses Mozilla JavaScript
            extensions.
+        :param javascript_strictness:
+            What sort of strictness to use in the JavaScript code. The
+            possible options are


colon : after are maybe

after how many params you have written, you are a master of it :D

sils · 2016-08-31T19:00:09Z

bears/js/JSHintBear.py

+            - "global" - there must be a ``"use strict";`` at global level
+            - "implied" - lint the code as if there is a ``"use strict";``
+            - False - disable warnings about strict mode
+            - True - there must be a ``"use strict";`` at function level


with this you're suggesting to the user that he should write "global" including the quotes as true and false are quoteless which isn't what we want right?

That is what I mean, "global" is a string, True and False are booleans. The data type is bool_or_str

hm still I think this is confusing for the user because he enters all of them as strings and it's not important for him.

Soo, I should be adding quotes here ?

or remove them in the other examples

gitmate-bot · 2016-08-31T21:25:59Z

tests/python/RadonBearTest.py

-                                             "radon_ranks_info": "",
-                                             "radon_ranks_normal": "A",
-                                             "radon_ranks_major": ""})
+    valid_files=(),


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/python/RadonBearTest.py +++ b/tests/python/RadonBearTest.py @@ -22,8 +22,9 @@ RadonBearReportsTest = verify_local_bear(RadonBear, - valid_files=(), - invalid_files=(test_file1, test_file2), - settings={"radon_ranks_info": "", - "radon_ranks_normal": "A", - "radon_ranks_major": ""}) + valid_files=(), + invalid_files=( + test_file1, test_file2), + settings={"radon_ranks_info": "", + "radon_ranks_normal": "A", + "radon_ranks_major": ""})

sils · 2016-09-03T16:05:13Z

ack fa70e92

sils · 2016-09-03T16:07:37Z

ack db8a2de

sils · 2016-09-03T16:08:28Z

unack a9c22db the commit message context in the shortlog is misleading, I'd just remove it

The PuppetLintBear runs the `puppet-lint` utility on files give by coala and gives results based on this. Closes #46

If eslint fails to run, for example if it gets an invalid config file it does not know how to handle, earlier the bear would throw a JSON Decoding error because it wouldn't know how to parse "" (an empty string). Now this case is handled, and it gracefull doesn't try to create results in such cases. Fixes #727

THe nltk versions were fixed a while back. THe comment is a remnant though, which can be removed now. Related to #509

Classes don't use snake casing, but rather CapWords convention according to PEP8.

This bear uses ``scspell`` to check for spelling mistakes. Closes #629

sils · 2016-09-03T16:09:56Z

ack a9c22db

sils · 2016-09-03T16:10:41Z

ooops I unacked it before... a9c22db needs work

sils · 2016-09-03T16:11:50Z

tests/js/ESLintBearTest.py

@@ -38,3 +38,12 @@
    ESLintBear,
    valid_files=(test_good, ''),
    invalid_files=(test_syntax_error, test_bad))
+
+# If there is an invalid config file, the results cannot be found. So, no
+# file gives a result.


can you file an issue about warning the user and link it here?

Already exist:
#730
coala/coala#2711

sils · 2016-09-03T16:12:13Z

ack 24598e5

sils · 2016-09-03T16:12:42Z

ack 41aa471

AbdealiLoKo · 2016-09-03T16:18:37Z

reack 5c72d4e 8a3d7fd

sils · 2016-09-03T16:29:32Z

ack 22cdc8a

sils · 2016-09-03T16:32:19Z

bears/configfiles/PuppetLintBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_FIX = {'Syntax'}


can you add an asciinema URL or file an issue about making one?

sils · 2016-09-03T16:38:39Z

ack c60e9f5

sils · 2016-09-03T16:38:44Z

ack 8a3d7fd

sils · 2016-09-03T16:39:24Z

ack 8a3d7fd

sils · 2016-09-03T16:45:23Z

ack ee34cdc b3be8f3

sils · 2016-09-03T16:45:30Z

@rultor merge

rultor · 2016-09-03T16:46:19Z

@rultor merge

@sils1297 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-09-03T16:47:44Z

@rultor merge

@sils1297 Done! FYI, the full log is here (took me 1min)

gitmate-bot added process/pending review size/S cautious review labels Aug 31, 2016

Adrianzatreanu reviewed Aug 31, 2016
View reviewed changes

Adrianzatreanu added process/wip and removed process/pending review labels Aug 31, 2016

AbdealiLoKo force-pushed the ajk/wip branch from 4a0a156 to fc7a0ad Compare August 31, 2016 16:18

gitmate-bot added process/pending review and removed process/wip labels Aug 31, 2016

AbdealiLoKo force-pushed the ajk/wip branch from fc7a0ad to c457f83 Compare August 31, 2016 16:19

AsnelChristian reviewed Aug 31, 2016
View reviewed changes

AbdealiLoKo force-pushed the ajk/wip branch from c457f83 to c660151 Compare August 31, 2016 18:37

sils reviewed Aug 31, 2016
View reviewed changes

sils added process/wip and removed process/pending review labels Aug 31, 2016

gitmate-bot added process/pending review size/L and removed process/wip size/S labels Aug 31, 2016

AbdealiLoKo changed the title ~~JSHint - deprecated args~~ Bear bug fixes - JSHint, JSComplexity Aug 31, 2016

AbdealiLoKo force-pushed the ajk/wip branch from 3b534b8 to d4a9654 Compare August 31, 2016 19:52

gitmate-bot reviewed Aug 31, 2016
View reviewed changes

AbdealiLoKo force-pushed the ajk/wip branch from bfc1f55 to 172255e Compare August 31, 2016 21:38

gitmate-bot added size/XL and removed size/L labels Aug 31, 2016

AbdealiLoKo and others added 5 commits September 3, 2016 21:39

bears.configfile: Add new bear - PuppetLintBear

ee34cdc

The PuppetLintBear runs the `puppet-lint` utility on files give by coala and gives results based on this. Closes #46

requirements: Remove redundant comment abot nltk

5c72d4e

THe nltk versions were fixed a while back. THe comment is a remnant though, which can be removed now. Related to #509

generate_packageTest: Use correct casing

8a3d7fd

Classes don't use snake casing, but rather CapWords convention according to PEP8.

natural_language: Add SpellCheckBear

b3be8f3

This bear uses ``scspell`` to check for spelling mistakes. Closes #629

sils reviewed Sep 3, 2016
View reviewed changes

AbdealiLoKo force-pushed the ajk/wip branch from 6e0ba60 to b3be8f3 Compare September 3, 2016 16:16

sils reviewed Sep 3, 2016
View reviewed changes

sils added process/approved and removed process/pending review labels Sep 3, 2016

rultor merged commit b3be8f3 into master Sep 3, 2016

jayvdb mentioned this pull request Jun 11, 2019

SpellCheckBear doesnt work on Windows #2926

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug solving sprint #747

Bug solving sprint #747

AbdealiLoKo commented Aug 31, 2016

Adrianzatreanu Aug 31, 2016

AsnelChristian Aug 31, 2016

Adrianzatreanu Aug 31, 2016

sils Aug 31, 2016

AbdealiLoKo Aug 31, 2016

sils Sep 3, 2016

AbdealiLoKo Sep 3, 2016

sils Sep 3, 2016

gitmate-bot Aug 31, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils Sep 3, 2016

AbdealiLoKo Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

AbdealiLoKo commented Sep 3, 2016

sils commented Sep 3, 2016

sils Sep 3, 2016

AbdealiLoKo Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

rultor commented Sep 3, 2016

rultor commented Sep 3, 2016

Bug solving sprint #747

Bug solving sprint #747

Conversation

AbdealiLoKo commented Aug 31, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Sep 3, 2016

sils commented Sep 3, 2016

AbdealiLoKo commented Sep 3, 2016

sils commented Sep 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

sils commented Sep 3, 2016

rultor commented Sep 3, 2016

rultor commented Sep 3, 2016