Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.rst: Update FAQ link #2825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README.rst: Update FAQ link #2825

wants to merge 1 commit into from

Conversation

ajupazhamayil
Copy link

This update helps direct jump to the actual FAQ page.

Closes #2821

@ajupazhamayil
README.rst: Update FAQ link
e8ac7be 
Updation helps direct jump to the actual FAQ page.

Closes coala#2821
naveentvelu
naveentvelu approved these changes Dec 12, 2018
View reviewed changes
Copy link

@naveentvelu naveentvelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct link has been updated.

utkarsh2102
utkarsh2102 approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
Although the changes are good, here are few things to note:

  • You should not open PRs until you're assigned the issue.
  • You should never close PRs, like you did.

@ajupazhamayil
Copy link
Author

@utkarsh2102, Thank you for your information. I will do in that lines from next time!

KVGarg
KVGarg reviewed Jan 6, 2019
View reviewed changes
README.rst
@@ -49,7 +49,7 @@ To also install all bears for coala at once, run:

Be sure to use the latest version of pip, the default pip from Debian doesn't
support our dependency version number specifiers. You will have to `use a
virtualenv <https://github.com/coala/coala/wiki/FAQ#installation-is-failing-help>`__
virtualenv <http://docs.coala.io/en/latest/Help/FAQ.html#installation-is-failing-help>`__
Copy link
Contributor

@KVGarg KVGarg Jan 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be https instead of http ?
on hovering over the paragraph link, at the bottom of page it shows https. In general also https is preferable than http.

shashank-b
shashank-b reviewed Jan 7, 2019
View reviewed changes
Copy link
Member

@shashank-b shashank-b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by KVGarg, 'http' can be changed to 'https' unless there is a good reason not to do so. Many other links in this doc are already using 'https' and the ones that are not are getting redirected to 'https' unlike this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVGarg KVGarg KVGarg left review comments

@shashank-b shashank-b shashank-b approved these changes

@utkarsh2102 utkarsh2102 utkarsh2102 approved these changes

@naveentvelu naveentvelu naveentvelu approved these changes

Assignees

@syamdanda syamdanda

Labels
area/documentation difficulty/newcomer process/wip size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ajupazhamayil @naveentvelu @shashank-b @utkarsh2102 @KVGarg @syamdanda @gitmate-bot @li-boxuan