SpaceConsistencyBear: Add leading_blankline option #2222

khanchi97 · 2018-01-08T14:01:46Z

Add allow_trailing_blanklines option for whether to allow
leading blanklines in starting of a file.

gitmate-bot · 2018-01-08T14:02:08Z

bears/general/SpaceConsistencyBear.py

+            line_nr_end = False
+            if not allow_leading_blanklines:
+                enumerated_zip_obj = zip(range(1, len(file) + 1),
+                                             file)


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6ju9xmm6/bears/general/SpaceConsistencyBear.py +++ b/tmp/tmp6ju9xmm6/bears/general/SpaceConsistencyBear.py @@ -45,7 +45,7 @@ line_nr_end = False if not allow_leading_blanklines: enumerated_zip_obj = zip(range(1, len(file) + 1), - file) + file) enumerated_tuple = tuple(enumerated_zip_obj) for line_number, line in enumerated_tuple:

gitmate-bot · 2018-01-08T14:02:09Z

bears/general/SpaceConsistencyBear.py

+                result_texts = []
+                additional_info_texts = []
+
+        for line_number, line in enumerate(file[start_line_of_file - 1:], start = start_line_of_file):


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp6ju9xmm6/bears/general/SpaceConsistencyBear.py +++ b/tmp/tmp6ju9xmm6/bears/general/SpaceConsistencyBear.py @@ -84,7 +84,7 @@ result_texts = [] additional_info_texts = [] - for line_number, line in enumerate(file[start_line_of_file - 1:], start = start_line_of_file): + for line_number, line in enumerate(file[start_line_of_file - 1:], start=start_line_of_file): replacement = line if enforce_newline_at_EOF:

gitmate-bot · 2018-01-08T14:02:10Z

bears/general/SpaceConsistencyBear.py

+            line_nr_end = False
+            if not allow_leading_blanklines:
+                enumerated_zip_obj = zip(range(1, len(file) + 1),
+                                             file)


E127 continuation line over-indented for visual indent

Origin: PycodestyleBear (E127), Section: autopep8.

gitmate-bot · 2018-01-08T14:02:11Z

bears/general/SpaceConsistencyBear.py

+                result_texts = []
+                additional_info_texts = []
+
+        for line_number, line in enumerate(file[start_line_of_file - 1:], start = start_line_of_file):


E251 unexpected spaces around keyword / parameter equals

Origin: PycodestyleBear (E251), Section: autopep8.

gitmate-bot · 2018-01-08T14:02:12Z

bears/general/SpaceConsistencyBear.py

+                result_texts = []
+                additional_info_texts = []
+
+        for line_number, line in enumerate(file[start_line_of_file - 1:], start = start_line_of_file):


E501 line too long (102 > 79 characters)

Origin: PycodestyleBear (E501), Section: autopep8.

gitmate-bot · 2018-01-08T14:02:13Z

bears/general/SpaceConsistencyBear.py

+                result_texts = []
+                additional_info_texts = []
+
+        for line_number, line in enumerate(file[start_line_of_file - 1:], start = start_line_of_file):


E251 unexpected spaces around keyword / parameter equals

Origin: PycodestyleBear (E251), Section: autopep8.

gitmate-bot · 2018-01-08T14:02:14Z

bears/general/SpaceConsistencyBear.py

+                result_texts = []
+                additional_info_texts = []
+
+        for line_number, line in enumerate(file[start_line_of_file - 1:], start = start_line_of_file):


Line is longer than allowed. (102 > 79)

Origin: LineLengthBear, Section: linelength.

Add allow_trailing_blanklines option for whether to allow leading blanklines in starting of a file. Closes coala#2207

shreyateeza

This should be merged @jayvdb

newbazz · 2018-01-09T18:25:07Z

tests/go/GoImportsBearTest.py

@@ -1,4 +1,3 @@
-


Why this change? I think you sud file a new issue for this or just include this in a different commit

newbazz · 2018-01-09T18:26:11Z

tests/c_languages/ClangBearTest.py

@@ -1,4 +1,3 @@
-
 from bears.c_languages.ClangBear import ClangBear


This as well ;)

@newbazz as I told you before :) this patch was shown in CI just because of feature that I have added ;)
you can see I deleted leading blanklines from these files.

thealphadollar

LGTM

ankitxjoshi

The enhancement works as required. Just some changes needed. Perform a rebase before pushing.

ankitxjoshi · 2018-04-09T16:41:17Z

bears/general/SpaceConsistencyBear.py

@@ -29,6 +30,9 @@ def run(self,
            True if spaces are to be used instead of tabs.
        :param allow_trailing_whitespace:
            Whether to allow trailing whitespace or not.
+        :param allow_leading_blanklines:
+            Whether to allow leading blanklines


blank lines not blanklines

ankitxjoshi · 2018-04-09T16:41:50Z

bears/general/SpaceConsistencyBear.py

@@ -29,6 +30,9 @@ def run(self,
            True if spaces are to be used instead of tabs.
        :param allow_trailing_whitespace:
            Whether to allow trailing whitespace or not.
+        :param allow_leading_blanklines:
+            Whether to allow leading blanklines
+            at start of file or not.


at the start not at start

ankitxjoshi · 2018-04-09T16:42:48Z

bears/general/SpaceConsistencyBear.py

@@ -38,7 +42,50 @@ def run(self,
        result_texts = []
        additional_info_texts = []

-        for line_number, line in enumerate(file, start=1):
+        def get_blanklines_nr_end():


Can we come up with a better name for the function? This name is quite misleading.

ankitxjoshi · 2018-04-09T16:44:05Z

bears/general/SpaceConsistencyBear.py

+            enumerated_tuple = tuple(enumerated_zip_obj)
+
+            for line_number, line in enumerated_tuple:
+                replacement = line


There is no need for a temporary variable. Python uses Call by Object Reference and not Pass by reference.

ankitxjoshi · 2018-04-09T16:45:46Z

bears/general/SpaceConsistencyBear.py

+                start_line_of_file = blanklines_nr_end + 1
+                result_texts.append('Leading blanklines.')
+                additional_info_texts.append(
+                    'Your source code contains leading blanklines.'


Again blank lines

ankitxjoshi · 2018-04-09T16:46:24Z

bears/general/SpaceConsistencyBear.py

+                result_texts.append('Leading blanklines.')
+                additional_info_texts.append(
+                    'Your source code contains leading blanklines.'
+                    'Those usually have no meaning. Please consider'


You missed a space after Please consider

ankitxjoshi · 2018-04-09T16:48:23Z

bears/general/SpaceConsistencyBear.py

@@ -38,7 +42,50 @@ def run(self,
        result_texts = []
        additional_info_texts = []

-        for line_number, line in enumerate(file, start=1):
+        def get_blanklines_nr_end():
+            line_nr_end = False


Again a better name for the variable.

jayvdb

See review by @MacBox7

jayvdb · 2018-04-21T23:06:50Z

bears/general/SpaceConsistencyBear.py

@@ -18,6 +18,7 @@ def run(self,
            file,
            use_spaces: bool,
            allow_trailing_whitespace: bool=False,
+            allow_leading_blanklines: bool=False,


add spaces around = ; new style requirement.

gitmate-bot added size/XS process/pending review labels Jan 8, 2018

gitmate-bot reviewed Jan 8, 2018

View reviewed changes

khanchi97 force-pushed the spaceConsistency-2207 branch 2 times, most recently from 35c71c6 to 540ef02 Compare January 8, 2018 14:50

SpaceConsistencyBear: Add leading_blankline option

d5865a5

Add allow_trailing_blanklines option for whether to allow leading blanklines in starting of a file. Closes coala#2207

khanchi97 force-pushed the spaceConsistency-2207 branch from 540ef02 to d5865a5 Compare January 9, 2018 08:25

shreyateeza approved these changes Jan 9, 2018

View reviewed changes

newbazz reviewed Jan 9, 2018

View reviewed changes

thealphadollar approved these changes Jan 11, 2018

View reviewed changes

jayvdb requested a review from ankitxjoshi April 9, 2018 13:43

ankitxjoshi suggested changes Apr 9, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Apr 10, 2018

jayvdb requested changes Apr 21, 2018

View reviewed changes

khanchi97 mentioned this pull request Mar 9, 2019

SpaceConsistencyBear: Remove leading blank lines option #2207

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SpaceConsistencyBear: Add leading_blankline option #2222

SpaceConsistencyBear: Add leading_blankline option #2222

khanchi97 commented Jan 8, 2018

gitmate-bot Jan 8, 2018

gitmate-bot Jan 8, 2018

gitmate-bot Jan 8, 2018

gitmate-bot Jan 8, 2018

gitmate-bot Jan 8, 2018

gitmate-bot Jan 8, 2018

gitmate-bot Jan 8, 2018

shreyateeza left a comment

newbazz Jan 9, 2018

newbazz Jan 9, 2018

khanchi97 Jan 9, 2018

thealphadollar left a comment

ankitxjoshi left a comment

ankitxjoshi Apr 9, 2018

ankitxjoshi Apr 9, 2018

ankitxjoshi Apr 9, 2018

ankitxjoshi Apr 9, 2018

ankitxjoshi Apr 9, 2018

ankitxjoshi Apr 9, 2018

ankitxjoshi Apr 9, 2018

jayvdb left a comment

jayvdb Apr 21, 2018

		@@ -1,4 +1,3 @@

		from bears.c_languages.ClangBear import ClangBear

SpaceConsistencyBear: Add leading_blankline option #2222

Are you sure you want to change the base?

SpaceConsistencyBear: Add leading_blankline option #2222

Conversation

khanchi97 commented Jan 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shreyateeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thealphadollar left a comment

Choose a reason for hiding this comment

ankitxjoshi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment