Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: Ignore lxml on avg installation #1931

Merged
merged 1 commit into from
Jul 20, 2017
Merged

setup: Ignore lxml on avg installation #1931

merged 1 commit into from
Jul 20, 2017

Conversation

sils
Copy link
Member

@sils sils commented Jul 15, 2017

@NiklasMM if this is good to you you'll wanna add it to your cherry PR :)

@jayvdb
Copy link
Member

jayvdb commented Jul 15, 2017

This doesnt help the average user, as they use pip, and pip uses the whl's , and wheel's dont run setup.py.

#1476 would provide one way to do this, effectively marking some bears as 'use at your own risk'.

And of course #1000 will solve this properly. (But that is waiting on improvements to package_manager which nobody seems to wont to work on unless I crack the whip).

@sils
Copy link
Member Author

sils commented Jul 15, 2017

This doesnt help the average user

It does, right now coala can't be installed without installing lxml via distribution and it gets the user a pretty mad looking error which isn't easy to understand.

With this we just don't install it by default, similar situation as language-check back then.


Another story:

I'm actually looking at dependency_manager/package_manager right now because the build is broken due to an issue there that we never found yet but once I enabled the super() check_prerequisites check for linter we got lots of more testcases.

On linux this worked totally fine but on windows we get exceptions from dependency manager.

@sils sils force-pushed the sils/req branch 2 times, most recently from 6539603 to 9569ccd Compare July 16, 2017 09:57
@AsnelChristian
Copy link
Member

ack 125acf4

@AsnelChristian
Copy link
Member

@rultor merge

@rultor
Copy link

rultor commented Jul 20, 2017

@rultor merge

@AsnelChristian OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 125acf4 into master Jul 20, 2017
@rultor
Copy link

rultor commented Jul 20, 2017

@rultor merge

@AsnelChristian Done! FYI, the full log is here (took me 2min)

@sils sils deleted the sils/req branch July 20, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants