KeywordBear: Handle empty keywords #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If setting keyword is used in coafile and not assigned, then keywords is an empty list, which leads to construction of regex `r'()'` which matches all the letters, hence yielding false results. Fixes coala#1689
|
ack 2221295 |
2 tasks
meetmangukiya
commented
May 2, 2017
| @@ -1,3 +1,11 @@ | |||
| coala-bears 0.10.2 | |||
There was a problem hiding this comment.
I assume since we are backporting we are making a release, hence added the release notes.
There was a problem hiding this comment.
and again I raise a conflict for myself :P
There was a problem hiding this comment.
erm I mean add to 0.11 0.10 neds to be assessed (probably needed too)
|
@Mixih this needs to be forward ported to 0.11 and master right? |
|
@sils, no, it is in master and also release branch |
|
@rultor merge |
|
@Mixih this being merged, how do we manage and synch relnotes across releases or in master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If setting keyword is used in coafile and not assigned, then keywords
is an empty list, which leads to construction of regex
r'()'whichmatches all the letters, hence yielding false results.
Fixes #1689
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!