Use PipRequirement in bears #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use nbformat~=4.1 instead of nbformat>=4.1 to be consistent with other entries in requirements.txt Closes coala#1212
Remove all bear requirements from requirements.txt, and use .ci/generate_bear_requirements.py to create and verify that the bear-requirements is identical to the PipRequirement found in the bears. Update the PipRequirement in the bears to match the versions currently being installed, and also remove the PipRequirement for libclang-py, as this dependency is provided by coala. Updates setup.py to add an extra 'alldeps' that is be used by CI to transition to explicitly requesting additional dependencies so 100% coverage and `coala --ci` work correctly. Uses pip to install wheels, as it supports extras while setup.py would require a non-standardised command line option to be added. Closes coala#1000
|
Thanks for your contribution! Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well! |
|
ack jayvdb@2b52dfe |
|
ack jayvdb@27a06d1 |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1000