Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAMLLintBear: Wrong argument "--config" #979

Closed
refeed opened this issue Nov 6, 2016 · 3 comments
Closed

YAMLLintBear: Wrong argument "--config" #979

refeed opened this issue Nov 6, 2016 · 3 comments

Comments

@refeed
Copy link
Member

refeed commented Nov 6, 2016

There is a wrong argument in YAMLLintBear.py

        if yamllint_config:
            args += ('--config=' + yamllint_config,)

At line 53, --config there should be --config-file, because there is no --config argument in yamllint.

Probably the unit test passed because coala didn't return any warning (zero code), however if I check it manually using yamllint, it will returns:

$ yamllint --config=conf.yml test.yml usage: yamllint [-h] [-c CONFIG_FILE] [-d CONFIG_DATA]
                [-f {parsable,standard}] [-v]
                FILE_OR_DIR [FILE_OR_DIR ...]
yamllint: error: ambiguous option: --config=conf.yml could match --config-file, --config-data
@Nosferatul
Copy link
Member

Thx for the report!

@meetarora29
Copy link
Member

I would like to do this. Please assign me this :)

@SanketDG
Copy link
Member

@meetarora29 You are assigned!

meetarora29 added a commit to meetarora29/coala-bears that referenced this issue Nov 13, 2016
Corrected the argument at line 53 to ``--config-file``

Fixes coala#979
meetarora29 added a commit to meetarora29/coala-bears that referenced this issue Nov 13, 2016
Corrected the argument at line 53 from ``--config`` to ``--config-file``

Fixes coala#979
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
Corrected the argument at line 53 from ``--config`` to ``--config-file``

Fixes coala#979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants