Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DartLintBear should error when use_spaces is False or indent_size is not 2 #897

Closed
jayvdb opened this issue Oct 12, 2016 · 0 comments
Closed

DartLintBear should error when use_spaces is False or indent_size is not 2 #897

jayvdb opened this issue Oct 12, 2016 · 0 comments
Assignees
@NiklasMM
Labels
difficulty/low importance/low size/S type/bug

Comments

@jayvdb
Copy link
Member

jayvdb commented Oct 12, 2016

dartanalyzer only performs indentation checking using 2 spaces, according to dart-lang/dart_style#261

use_spaces=False must emit an error
indent_size must be set to 2, otherwise emit an error
@NiklasMM NiklasMM mentioned this issue Oct 28, 2016
Merged
@jayvdb jayvdb mentioned this issue Nov 18, 2016
Merged
@jayvdb jayvdb mentioned this issue May 23, 2017
Closed
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@NiklasMM
DartLintBear: Check settings validity
4983c39 
As pointed out here dart-lang/dart_style#261,
dartanalyzer only supports indentation using 2 spaces. This commit
changes DartLintBear to check that ``use_spaces`` is True and
``indent_size`` is 2 and raises a ``ValueError`` if not.

Fixes coala#897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasMM NiklasMM

Labels
difficulty/low importance/low size/S type/bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @NiklasMM @Adrianzatreanu