Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YapfBear adds redundant newline to empty files #739

Closed
sils opened this issue Aug 30, 2016 · 3 comments
Closed

YapfBear adds redundant newline to empty files #739

sils opened this issue Aug 30, 2016 · 3 comments
Assignees
@AbdealiLoKo
Labels
difficulty/low importance/high type/bug

Comments

@sils
Copy link
Member

sils commented Aug 30, 2016

type/bug
@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue! A coalaian will look at it soon.

@sils
Copy link
Member Author

sils commented Aug 31, 2016

there's no workaround for this

@AbdealiLoKo AbdealiLoKo self-assigned this Aug 31, 2016
AbdealiLoKo added a commit that referenced this issue Aug 31, 2016
@AbdealiLoKo
YapfBear: Ignore file if it is zero-byte file
d4a9654 
Yapf cannot handle zero-byte files correctly, because it adds a newline
into the file when correcting. Hence we ignore zero byte files
completely as they anyway do not have code to format.

Fixes #739
AbdealiLoKo added a commit that referenced this issue Sep 1, 2016
@AbdealiLoKo
YapfBear: Ignore file if it is zero-byte file
2a542e6 
Yapf cannot handle zero-byte files correctly, because it adds a newline
into the file when correcting. Hence we ignore zero byte files
completely as they anyway do not have code to format.

Fixes #739
AbdealiLoKo added a commit that referenced this issue Sep 2, 2016
@AbdealiLoKo
YapfBear: Ignore file if it is zero-byte file
d6b4124 
Yapf cannot handle zero-byte files correctly, because it adds a newline
into the file when correcting. Hence we ignore zero byte files
completely as they anyway do not have code to format.

Fixes #739
@sils
Copy link
Member Author

sils commented Sep 2, 2016

CC @netman92 because we'll need it just so you know a fix is on the way, I'll release it todayish

@rultor rultor closed this as completed in 53feb78 Sep 2, 2016
sils pushed a commit that referenced this issue Sep 2, 2016
@AbdealiLoKo @sils
YapfBear: Ignore file if it is zero-byte file
52aba6b 
Yapf cannot handle zero-byte files correctly, because it adds a newline
into the file when correcting. Hence we ignore zero byte files
completely as they anyway do not have code to format.

Fixes #739
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@AbdealiLoKo @sils
YapfBear: Ignore file if it is zero-byte file
c7880e5 
Yapf cannot handle zero-byte files correctly, because it adds a newline
into the file when correcting. Hence we ignore zero byte files
completely as they anyway do not have code to format.

Fixes coala#739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdealiLoKo AbdealiLoKo

Labels
difficulty/low importance/high type/bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AbdealiLoKo @sils @gitmate-bot