-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YapfBear fails on python 2 code #738
Comments
Thanks for reporting this issue! A coalaian will look at it soon. |
Ideally we would offer an option python 2/3 and run yapf with python 2 or 3 as an external process respectively as yapf will then do the right thing. (Maybe there is a way without switching interpreters? At least official docs say that this is how you should do it which makes sense outside coala.) |
underyx
added a commit
to underyx/coala-bears
that referenced
this issue
Aug 31, 2016
Syntax verification is supposed to be a private feature in yapf, used for debugging, but they're still defaulting its flag to True on the public FormatFile function. We need to set it to False to disable syntax error checking in yapf (which seems to be an unmaintained feature of it, since it raises exceptions on async/await and py2 print syntax), see discussion at google/yapf#293 Fixes coala#738
underyx
added a commit
to underyx/coala-bears
that referenced
this issue
Aug 31, 2016
Syntax verification is supposed to be a private feature in yapf, used for debugging, but they're still defaulting its flag to True on the public FormatFile function. We need to set it to False to disable syntax error checking in yapf (which seems to be an unmaintained feature of it, since it raises exceptions on async/await and Python 2's print statement), see discussion at google/yapf#293 Fixes coala#738
underyx
added a commit
to underyx/coala-bears
that referenced
this issue
Aug 31, 2016
Syntax verification is supposed to be a private feature in yapf, used for debugging, but they're still defaulting its flag to True on the public FormatFile function. We need to set it to False to disable syntax error checking in yapf (which seems to be an unmaintained feature of it, since it raises exceptions on async/await and Python 2's print statement), see discussion at google/yapf#293 Fixes coala#738
underyx
added a commit
to underyx/coala-bears
that referenced
this issue
Aug 31, 2016
Syntax verification is supposed to be a private feature in yapf, used for debugging, but they're still defaulting its flag to True on the public FormatFile function. We need to set it to False to disable syntax error checking in yapf (which seems to be an unmaintained feature of it, since it raises exceptions on async/await and Python 2's print statement), see discussion at google/yapf#293 Fixes coala#738
underyx
added a commit
to underyx/coala-bears
that referenced
this issue
Aug 31, 2016
Syntax verification is supposed to be a private feature in yapf, used for debugging, but they're still defaulting its flag to True on the public FormatFile function. We need to set it to False to disable syntax error checking in yapf (which seems to be an unmaintained feature of it, since it raises exceptions on async/await and Python 2's print statement), see discussion at google/yapf#293 Fixes coala#738
sils
pushed a commit
that referenced
this issue
Sep 1, 2016
Syntax verification is supposed to be a private feature in yapf, used for debugging, but they're still defaulting its flag to True on the public FormatFile function. We need to set it to False to disable syntax error checking in yapf (which seems to be an unmaintained feature of it, since it raises exceptions on async/await and Python 2's print statement), see discussion at google/yapf#293 Fixes #738
gosom
pushed a commit
to gosom/coala-bears
that referenced
this issue
Jul 15, 2017
Syntax verification is supposed to be a private feature in yapf, used for debugging, but they're still defaulting its flag to True on the public FormatFile function. We need to set it to False to disable syntax error checking in yapf (which seems to be an unmaintained feature of it, since it raises exceptions on async/await and Python 2's print statement), see discussion at google/yapf#293 Fixes coala#738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
we either should state that it can't deal with python 2 or make it deal with it correctly. Or at least catch the
yapf.yapflib.verifier.InternalError: Missing parentheses in call to 'print' (<string>, line 2)
...The text was updated successfully, but these errors were encountered: