Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False postive collection for invalidlinkbear #691

Closed
6 of 7 tasks
sils opened this issue Aug 15, 2016 · 8 comments
Closed
6 of 7 tasks

False postive collection for invalidlinkbear #691

sils opened this issue Aug 15, 2016 · 8 comments

Comments

@sils
Copy link
Member

sils commented Aug 15, 2016

  • From InvalidLinkBear false positive #685: http://www.w3.org/Consortium/Legal/</h3
  • http://cran.rstudio.com').install_command()
  • http://www.spice-space.org/download.html\">http://www.spice-space.org/
  • http://cran.rstudio.com\
  • A URL with xmln(s|s:\S+)= directly in front isn't necessarily valid.
  • //domain.com/img/logo.png should be tried with http and https I think
  • In XML:
-      <image>http://people.gnome.org/~zeeshanak/screenshots/gnome-boxes-selection.png</image>
+      <image>https://people.gnome.org/~zeeshanak/screenshots/gnome-boxes-selection.png%3C/image>
@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue! A coalaian will look at it soon.

sils added a commit that referenced this issue Aug 15, 2016
sils added a commit that referenced this issue Aug 15, 2016
sils added a commit that referenced this issue Aug 15, 2016
There's no valid usecase for those, only false positives.

Related: #691
sils added a commit that referenced this issue Aug 15, 2016
sils added a commit that referenced this issue Aug 15, 2016
Instead of nonspaces, a lot of other special characters aren't allowed
according to the URL spec. This change mirrors that and thus reduces
false positives.

Related: #691
sils added a commit that referenced this issue Aug 15, 2016
There's no valid usecase for those, only false positives.

Related: #691
@sils
Copy link
Member Author

sils commented Aug 16, 2016

  • So also we should do something about templates:
plugins/steam/src/steam-cover.vala
|  26| »   »   var•uri•=•@"http://cdn.akamai.steamstatic.com/steam/apps/$game_id/header.jpg";
|    | [NORMAL] InvalidLinkBear:
|    | Broken link - unable to connect to http://cdn.akamai.steamstatic.com/steam/apps/$game_id/header.jpg (HTTP Error: 404)

sils added a commit that referenced this issue Aug 16, 2016
sils added a commit that referenced this issue Aug 16, 2016
Instead of nonspaces, a lot of other special characters aren't allowed
according to the URL spec. This change mirrors that and thus reduces
false positives.

Related: #691
sils added a commit that referenced this issue Aug 16, 2016
There's no valid usecase for those, only false positives.

Related: #691
sils added a commit that referenced this issue Aug 16, 2016
@jack17529
Copy link

[ ] 1. write a python code to make URL with xmln(s|s:\S+)= directly in front invalid.
[ ] 2.//domain.com/img/logo.png should be tried with http and https and make a Python code.

Can't understand xml point can someone please elaborate?

@jack17529
Copy link

please assign me this if I am right.

@jayvdb
Copy link
Member

jayvdb commented Jun 8, 2017

@refeed, can you check which of these examples are still a problem.
Create separate issues for any obvious distinct problems, and we'll discuss any of the less clear problems.
Then we can close this "omnibus" issue.

@refeed
Copy link
Member

refeed commented Jun 9, 2017

//domain.com/img/logo.png should be tried with http and https I think

Opened an issue for this on #1827

A URL with xmln(s|s:\S+)= directly in front isn't necessarily valid.

That issue has been fixed in 7f99537 by reducing the severity.

-      <image>http://people.gnome.org/~zeeshanak/screenshots/gnome-boxes-selection.png</image>
+      <image>https://people.gnome.org/~zeeshanak/screenshots/gnome-boxes-selection.png%3C/image>

Also has been fixed, (when I run InvalidLinkBear to analyze that file, it runs correctly) I think it's fixed in a8e4bab

So also we should do something about templates:

Fixed in 25493f6

@sils
Copy link
Member Author

sils commented Jun 9, 2017

ok then this can be closed with only #1827 left right? Thanks a lot for the investigation, that's what was needed here.

@sils sils closed this as completed Jun 9, 2017
@refeed
Copy link
Member

refeed commented Jun 9, 2017

Right :)

gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
Instead of nonspaces, a lot of other special characters aren't allowed
according to the URL spec. This change mirrors that and thus reduces
false positives.

Related: coala#691
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
There's no valid usecase for those, only false positives.

Related: coala#691
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants