Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxml 4.4.0 dropped support for Python 3.4 #2940

Closed
abhishalya opened this issue Jul 30, 2019 · 9 comments
Closed

lxml 4.4.0 dropped support for Python 3.4 #2940

abhishalya opened this issue Jul 30, 2019 · 9 comments

Comments

@abhishalya
Copy link
Member

Need to cap below 4.4.0.

abhishalya added a commit to abhishalya/coala-bears that referenced this issue Jul 30, 2019
lxml 4.4.0 dropped support for Python 3.4.
Hence, the version is capped below 4.4.0.

Closes coala#2940
@jayvdb
Copy link
Member

jayvdb commented Aug 3, 2019

This should be done like moremoban/moban@5e895b6 , so that newer versions of Python are not effected.

Also the lxml dependency is special, and is managed in the .ci/deps.python-packages.ps1 for Windows so that it is installed with special flags. That fix needs to be done in mobans repo, as lxml is important in all repos.

@jayvdb
Copy link
Member

jayvdb commented Aug 4, 2019

Where is this breaking a build ?

@abhishalya
Copy link
Member Author

I saw it here. Now it seems we have even more build failures.

@jayvdb
Copy link
Member

jayvdb commented Aug 4, 2019

Also triggered at coala/coala#6054 . Annoying.

jayvdb added a commit to jayvdb/coala that referenced this issue Aug 5, 2019
Implements https://gitlab.com/coala/mobans/merge_requests/135
working around the lxml dependency problem on Python 3.4.

coala#6053 is only
occurring in the Travis trusty environment.
Upgrading to xenial bypasses that problem, but
requires a few workarounds, especially replacing the
Python 3.4.2 job with Python '3.4' which causes
Travis to provide Python 3.4.8.

Add gravis to template to switch jdk versions on Xenial.

Uninstall setuptools multiple times on Xenial for the same
reason it was required once on Trusty.  Also remove
unnecessary pipenv which causes pip to complain about
incompatibilities.

Disable new template for JinjaBear due to its inability
to handle indentation.

.misc/check_moban.sh is no longer needed as the
Travis template provides a moban job, and the latest
moban handles branches.

Related to coala#4708
Related to coala#6053
Related to coala/coala-bears#2940
jayvdb added a commit to jayvdb/coala that referenced this issue Aug 5, 2019
Implements https://gitlab.com/coala/mobans/merge_requests/135
working around the lxml dependency problem on Python 3.4.

coala#6053 is only
occurring in the Travis trusty environment.
Upgrading to xenial bypasses that problem, but
requires a few workarounds, especially replacing the
Python 3.4.2 job with Python '3.4' which causes
Travis to provide Python 3.4.8.

Add gravis to template to switch jdk versions on Xenial.

Uninstall setuptools multiple times on Xenial for the same
reason it was required once on Trusty.  Also remove
unnecessary pipenv which causes pip to complain about
incompatibilities.

Bump setuptools dependency to match the version defined
in mobans.

Disable new template for JinjaBear due to its inability
to handle indentation.

.misc/check_moban.sh is no longer needed as the
Travis template provides a moban job, and the latest
moban handles branches.

Related to coala#4708
Related to coala#6053
Related to coala/coala-bears#2940
@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2019

Temporary solution in https://gitlab.com/coala/mobans/merge_requests/135 , deploying to coala and coala-quickstart.

jayvdb added a commit to jayvdb/coala-bears that referenced this issue Aug 5, 2019
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Aug 5, 2019
jayvdb pushed a commit to jayvdb/coala-bears that referenced this issue Aug 5, 2019
lxml 4.4.0 dropped support for Python 3.4.
Hence, the version is capped below 4.4.0.

Closes coala#2940
@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2019

Cherry-picked abhishalya@bf3b7a2 onto #2942 . Note I needed to also update the pin in bear-requirements.txt and adjusted the commit message a little .

Feel free to create a PR with it and ill rebase on top of your PR. Otherwise, your commit will show it was amended by me. Up to you

@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2019

The reason it was needed, despite the pre-install, is that tox on Unix is not using 'site-packages' so versions installed outside the tox venv are not visible inside, so tox tries to use an old pip to install lxml, and fails.
https://travis-ci.org/jayvdb/coala-bears/jobs/567832173

This should be done like moremoban/moban@5e895b6 , so that newer versions of Python are not effected.

The minreqs templates should be implemented in all our repos, and will very likely reveal that our minimum versions are wrong.

The new travis templates do support this, but we should start with the gitlab-ci templates for the gitlab repos, as their minimums effect coala core and coala bears.

Also the lxml dependency is special, and is managed in the .ci/deps.python-packages.ps1 for Windows so that it is installed with special flags. That fix needs to be done in mobans repo, as lxml is important in all repos.

No change is necessary in mobans, as the currently logic in .ci/deps.python-packages.ps1 uses the latest pip and --prefer-binary picks the latest binary version for py34, which happens to be the older version because none are built for py34.

@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2019

We currently dont have support for dependencies for per-Python-version ('constraints'), and I suspect that is going to take a while, so we can revisit this problem whenever we find that <4.4.0 is causing some other bug.

jayvdb pushed a commit to jayvdb/coala-bears that referenced this issue Aug 5, 2019
lxml 4.4.0 dropped support for Python 3.4.
Hence, the version is capped below 4.4.0.

Closes coala#2940
@abhishalya
Copy link
Member Author

Cherry-picked abhishalya/coala-bears@bf3b7a2 onto #2942 . Note I needed to also update the pin in bear-requirements.txt and adjusted the commit message a little .

No problem 👍

jayvdb added a commit to jayvdb/coala that referenced this issue Aug 7, 2019
Implements https://gitlab.com/coala/mobans/merge_requests/135
working around the lxml dependency problem on Python 3.4.

coala#6053 is only
occurring in the Travis trusty environment.
Upgrading to xenial bypasses that problem, but
requires a few workarounds, especially replacing the
Python 3.4.2 job with Python '3.4' which causes
Travis to provide Python 3.4.8.

Add gravis to template to switch jdk versions on Xenial.

Uninstall setuptools multiple times on Xenial for the same
reason it was required once on Trusty.  Also remove
unnecessary pipenv which causes pip to complain about
incompatibilities.

Bump setuptools dependency to match the version defined
in mobans.

.misc/check_moban.sh is no longer needed as the
Travis template provides a moban job, and the latest
moban handles branches.

Related to coala#4708
Related to coala#6053
Related to coala/coala-bears#2940
akshatkarani pushed a commit to akshatkarani/coala that referenced this issue Aug 7, 2019
Implements https://gitlab.com/coala/mobans/merge_requests/135
working around the lxml dependency problem on Python 3.4.

coala#6053 is only
occurring in the Travis trusty environment.
Upgrading to xenial bypasses that problem, but
requires a few workarounds, especially replacing the
Python 3.4.2 job with Python '3.4' which causes
Travis to provide Python 3.4.8.

Add gravis to template to switch jdk versions on Xenial.

Uninstall setuptools multiple times on Xenial for the same
reason it was required once on Trusty.  Also remove
unnecessary pipenv which causes pip to complain about
incompatibilities.

Bump setuptools dependency to match the version defined
in mobans.

.misc/check_moban.sh is no longer needed as the
Travis template provides a moban job, and the latest
moban handles branches.

Related to coala#4708
Related to coala#6053
Related to coala/coala-bears#2940
akshatkarani pushed a commit to akshatkarani/coala that referenced this issue Aug 7, 2019
Implements https://gitlab.com/coala/mobans/merge_requests/135
working around the lxml dependency problem on Python 3.4.

coala#6053 is only
occurring in the Travis trusty environment.
Upgrading to xenial bypasses that problem, but
requires a few workarounds, especially replacing the
Python 3.4.2 job with Python '3.4' which causes
Travis to provide Python 3.4.8.

Add gravis to template to switch jdk versions on Xenial.

Uninstall setuptools multiple times on Xenial for the same
reason it was required once on Trusty.  Also remove
unnecessary pipenv which causes pip to complain about
incompatibilities.

Bump setuptools dependency to match the version defined
in mobans.

.misc/check_moban.sh is no longer needed as the
Travis template provides a moban job, and the latest
moban handles branches.

Related to coala#4708
Related to coala#6053
Related to coala/coala-bears#2940
@jayvdb jayvdb closed this as completed in 6faac13 Aug 7, 2019
Utkarsh1308 pushed a commit to Utkarsh1308/coala that referenced this issue Aug 20, 2019
Implements https://gitlab.com/coala/mobans/merge_requests/135
working around the lxml dependency problem on Python 3.4.

coala#6053 is only
occurring in the Travis trusty environment.
Upgrading to xenial bypasses that problem, but
requires a few workarounds, especially replacing the
Python 3.4.2 job with Python '3.4' which causes
Travis to provide Python 3.4.8.

Add gravis to template to switch jdk versions on Xenial.

Uninstall setuptools multiple times on Xenial for the same
reason it was required once on Trusty.  Also remove
unnecessary pipenv which causes pip to complain about
incompatibilities.

Bump setuptools dependency to match the version defined
in mobans.

.misc/check_moban.sh is no longer needed as the
Travis template provides a moban job, and the latest
moban handles branches.

Related to coala#4708
Related to coala#6053
Related to coala/coala-bears#2940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants