Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommitBear: Check whether GitLab autoclose works with http as well as https #2722

Closed
jayvdb opened this issue Oct 21, 2018 · 2 comments · Fixed by #2755
Closed

CommitBear: Check whether GitLab autoclose works with http as well as https #2722

jayvdb opened this issue Oct 21, 2018 · 2 comments · Fixed by #2755
Assignees
@samuelpiltch @abhishalya
Labels
difficulty/low importance/low initiatives/gci status/needs info

Comments

@jayvdb
Copy link
Member

jayvdb commented Oct 21, 2018

CommitBear: Create a demo on GitLab, like @li-boxuan did at #2683 , to prove whether autoclosing works with http:// .

Then either fix GitLab in CommitBear, or add a comment to explain http:// works.
@abhishalya
Copy link
Member

@jayvdb I checked this on Gitlab and I confirm that the Gitlab behaves the same as Github.

Using http in the issue url won't close the issue after the PR is merged, whereas if https is used as the issue url in the PR, it will close the corresponding issue automatically.

These are the links where I tried this:

Issue: https://gitlab.com/abhishalya/gitlab_playground/issues/1
MR-1: https://gitlab.com/abhishalya/gitlab_playground/merge_requests/1 (http)
MR-2: https://gitlab.com/abhishalya/gitlab_playground/merge_requests/2 (https)

@samuelpiltch samuelpiltch mentioned this issue Nov 6, 2018
Merged
@jayvdb
Copy link
Member Author

jayvdb commented Nov 11, 2018

This issue reserved for Google Code-in task 5630451499663360.

ZamaSharik pushed a commit to ZamaSharik/coala-bears that referenced this issue Nov 15, 2018
@samuelpiltch @ZamaSharik
CommitBear.py: Check https use in issue references
3091131 
Check if commit message uses 'https' rather than 'http' to automatically
close the referenced issue for GitHub and GitLab. Error message now
includes host.

Closes coala#2683
Closes coala#2722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelpiltch samuelpiltch

@abhishalya abhishalya

Labels
difficulty/low importance/low initiatives/gci status/needs info
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CommitBear.py: Check proper use of https when referencing issues
3 participants
@jayvdb @samuelpiltch @abhishalya