Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CheckstyleBear version #2711

Closed
li-boxuan opened this issue Oct 13, 2018 · 3 comments
Closed

Bump CheckstyleBear version #2711

li-boxuan opened this issue Oct 13, 2018 · 3 comments
Labels
difficulty/low importance/low type/bug

Comments

@li-boxuan
Copy link
Member

CheckstyleBear uses checkstyle version 6.19

coala-bears/bears/java/CheckstyleBear.py

Line 16 in c449f27

_checkstyle_version = '6.19'

while the latest release is version 8.13 http://checkstyle.sourceforge.net/releasenotes.html

checkstyle v8.13 fixes a bug checkstyle/checkstyle#6000. Thus, 401fa88#diff-2da2a90312219c9c8a1609b340cd39c7R38 can be removed. But tests should be added to verify that.
@li-boxuan
Copy link
Member Author

coala/coala#5601 This may help to understand remove_zero_numbers linter bear option.

@jayvdb
Copy link
Member

jayvdb commented Oct 13, 2018

Duplicate of #1675 ?

@li-boxuan
Copy link
Member Author

Duplicate of #1675 ?

Seems so, but this issue is talking about a workaround that can be removed when upgrading to checkstyle 8.13. Let me mention it in #1675 and close this issue.

@li-boxuan li-boxuan mentioned this issue Oct 13, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/low importance/low type/bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @gitmate-bot @li-boxuan