Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to checkstyle 7.6 #1675

Open
jayvdb opened this issue Apr 26, 2017 · 2 comments
Open

Upgrade to checkstyle 7.6 #1675

jayvdb opened this issue Apr 26, 2017 · 2 comments
Labels
status/needs design
Milestone
0.12

Comments

@jayvdb
Copy link
Member

jayvdb commented Apr 26, 2017

As found on #1466 , checkstyle 7.6 jar is compiled with JDK 8, and will not run on JDK 7, at least on Windows.

To workaround this, we would need to detect the version of Java installed, and then either use checkstyle 6.19 or 7.6 accordingly.
@jayvdb jayvdb mentioned this issue Apr 26, 2017
Open
2 tasks
@jayvdb jayvdb added this to the 0.12 milestone Apr 27, 2017
@jayvdb jayvdb mentioned this issue Apr 28, 2017
Open
@aepfli
Copy link

aepfli commented Jan 7, 2018

just a note/input, maybe this should be a little bit more future proof, and handled with user configuration (defining checkstyle version) -> just a suggestion, because this Ticket was started in April and checkstyle also advanced to version 8.7 (http://checkstyle.sourceforge.net/releasenotes.html)

@jayvdb jayvdb mentioned this issue Oct 13, 2018
Closed
@li-boxuan
Copy link
Member

When upgrading to 8.13, also need to do what is requested by this issue: #2711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/needs design
Milestone
0.12
Development

No branches or pull requests
6 participants
@jayvdb @Makman2 @aepfli @vijeth-aradhya @gitmate-bot @li-boxuan