Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyImportSortBear add more args #26

Closed
sils opened this issue Feb 21, 2016 · 11 comments
Closed

PyImportSortBear add more args #26

sils opened this issue Feb 21, 2016 · 11 comments

Comments

@sils
Copy link
Member

sils commented Feb 21, 2016

From @AbdealiJK on February 10, 2016 20:42

https://github.com/timothycrosley/isort/wiki/isort-Settings

known first and third party imports needs to be added to PyImportSortBear

Copied from original issue: coala/coala#1403

@ravinimmi
Copy link
Member

@sils1297 Please assign me.

@sils
Copy link
Member Author

sils commented Feb 23, 2016

@ravinimmi you're way beyond newcomer status, we'd like to ask you to leave this and other newcomer issues to actual newcomers because we struggle to come up with enough newcomer issues.

@AbdealiLoKo
Copy link
Contributor

Hi @ravinimmi I notice you've already solved a few issues. Could you do some difficulty/low issues now ?
We normally prefer it when people only do 1-2 newcomer issues

@ravinimmi
Copy link
Member

@sils1297 @AbdealiJK Ok, got it.

@AbdealiLoKo
Copy link
Contributor

Ive invited you to the org. We can assign you once youve joined

@sils
Copy link
Member Author

sils commented Mar 1, 2016

@AbdealiJK who?

@AbdealiLoKo
Copy link
Contributor

@abpnd12 had commented on this saying he wanted to do it (I still have the mail) ... I think he deleted the comment ?

@abhijeetpanda12
Copy link

@AbdealiJK thank you for adding me, I'm still having issues while playing with the code so I deleted the comment . I'm sorry if it created any issue.

@AbdealiLoKo
Copy link
Contributor

@abpnd12 Well, it's better not to delete stuff - rather comment again (otherwise it gets confusing)

And, do you still want to be assigned to this issue ?

@abhijeetpanda12
Copy link

not now, I'm having problems while understanding the code

@AbdealiLoKo
Copy link
Contributor

Removing newcomer as it's blocking coala/coala#1529

@AbdealiLoKo AbdealiLoKo self-assigned this Apr 26, 2016
AbdealiLoKo added a commit that referenced this issue Apr 26, 2016
AbdealiLoKo added a commit that referenced this issue Apr 26, 2016
AbdealiLoKo added a commit that referenced this issue Apr 26, 2016
@rultor rultor closed this as completed in fb12419 Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants